3.10 #312
Merged
3.10 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huthomas
requested changes
Feb 5, 2024
Comment on lines
+94
to
+98
| MessageDialog.openInformation(Display.getDefault().getActiveShell(), "Ansicht veraltet", "Die Ansicht " | ||
| + getTitle() | ||
| + " ist veraltet und wird nicht mehr unterstützt. Bitte verwenden Sie die Agenda Web Ansicht."); | ||
| isFirstTime = false; | ||
| } |
There was a problem hiding this comment.
In AgendaWeek (unteres file) werden die messages verwendet, und hier nicht. Bitte hier auch die dafür im core angelegten messages verwenden.
|
Unabhängig von dem obigen Kommentar noch die Frage weshalb dieser pull request gegen 3.10 geht und nicht gegen den master? |
|
@victoriacarola @huthomas ist das noch relevant, ansonsten bitte schliessen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.