-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ele 3771 have a single insert rows method that supports both limits #765
Ele 3771 have a single insert rows method that supports both limits #765
Conversation
👋 @haritamar |
! contains(github.event_name, 'pull_request') && fromJSON('["1.3.0", "latest_pre"]') || | ||
fromJSON('["latest_pre"]') }} | ||
! contains(github.event_name, 'pull_request') && fromJSON('["1.3.0", "latest_official"]') || | ||
fromJSON('["latest_official"]') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some pre versions are broken again, and I want tests to work.
I added a latest_pre
run only on postgres so if there are cross-db things that break we'll notice, wdyt about this middle ground?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't query_max_size different for different warehousing solutions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Niteeshkanungo - my comment above is specifically about testing on dbt pre-releases.
After the change above we will still run on all warehouses with the latest official dbt version, but test the latest dbt pre-release (right now 1.9.0b3
) only on postgres.
No description provided.