Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ele 3771 have a single insert rows method that supports both limits #765

Conversation

haritamar
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Nov 5, 2024

Copy link
Contributor

github-actions bot commented Nov 5, 2024

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

! contains(github.event_name, 'pull_request') && fromJSON('["1.3.0", "latest_pre"]') ||
fromJSON('["latest_pre"]') }}
! contains(github.event_name, 'pull_request') && fromJSON('["1.3.0", "latest_official"]') ||
fromJSON('["latest_official"]') }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pre versions are broken again, and I want tests to work.
I added a latest_pre run only on postgres so if there are cross-db things that break we'll notice, wdyt about this middle ground?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't query_max_size different for different warehousing solutions?

Copy link
Collaborator Author

@haritamar haritamar Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Niteeshkanungo - my comment above is specifically about testing on dbt pre-releases.
After the change above we will still run on all warehouses with the latest official dbt version, but test the latest dbt pre-release (right now 1.9.0b3) only on postgres.

@haritamar haritamar merged commit 3437eef into master Nov 6, 2024
12 of 13 checks passed
@haritamar haritamar deleted the ele-3771-have-a-single-insert_rows-method-that-supports-both-limits branch November 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants