[Android] Fix: split editor and message mode in html parsing #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we translated HTML to spans in Android, we want the paragraph tags (`<p>`) to translate to a double line break ( `\n\n`) since Android doesn't have support for inter-paragraph spacing and we need to simulate this by using this workaround. However, this is not something we can support in the actual editor since it would break the index matching, add new points in the text that can be selected, removed, etc. and would make it crash. So we end up having to differentiate between HTML parsing for the editor and HTML parsing to display in messages to support this change. Also, this means the rendering on the editor and what's rendered later for the sent message might not match 1:1 as until now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 90.16% 89.33% -0.83%
==========================================
Files 179 104 -75
Lines 22240 18008 -4232
Branches 291 291
==========================================
- Hits 20053 16088 -3965
+ Misses 2184 1917 -267
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jmartinesp
force-pushed
the
fix/android-split-editor-and-message-mode-in-html-parser
branch
14 times, most recently
from
c894cf6
to
1d5ddc2
Compare
|
I had to also workaround the NDK version selection, which for some reason didn't work in CI anymore... |
jmartinesp
force-pushed
the
fix/android-split-editor-and-message-mode-in-html-parser
branch
from
1d5ddc2
to
717f285
Compare
jmartinesp
force-pushed
the
fix/android-split-editor-and-message-mode-in-html-parser
branch
from
717f285
to
3799726
Compare
|
jmartinesp
deleted the
fix/android-split-editor-and-message-mode-in-html-parser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we translate HTML to spans in Android, we want the paragraph tags (
<p>) to translate to a double line break (\n\n) since Android doesn't have support for inter-paragraph spacing and we need to simulate this by using this workaround.However, this is not something we can support in the actual editor since it would break the index matching, add new points in the text that can be selected, removed, etc. and would make it crash.
So we end up having to differentiate between HTML parsing for the editor and HTML parsing to display in messages to support this change. Also, this means the rendering on the editor and what's rendered later for the sent message might not match 1:1 as until now.