Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable configuration cache in the CI by default #3601

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Oct 4, 2024

Content

Disable configuration cache for all Gradle CI jobs.

Motivation and context

Gradle configuration cache can be a nice trick to speed up builds, but it's also a bit unstable.

While locally we can just re-run a task with --no-configuration-cache or disable the org.gradle.configuration-cache Gradle property, in the CI we can't do that to fix a flaky job running with a mismatched config cache and we've seen several of those already, so I'm disabling the cache in the CI for now.

Tests

The CI should just pass.

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AmtR5z

Copy link

sonarcloud bot commented Oct 4, 2024

@jmartinesp jmartinesp marked this pull request as ready for review October 4, 2024 07:47
@jmartinesp jmartinesp requested a review from a team as a code owner October 4, 2024 07:48
@jmartinesp jmartinesp requested review from bmarty and removed request for a team October 4, 2024 07:48
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (c1337de) to head (c947f01).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3601      +/-   ##
===========================================
+ Coverage    82.15%   82.68%   +0.53%     
===========================================
  Files         1747     1731      -16     
  Lines        42740    41008    -1732     
  Branches      5068     4973      -95     
===========================================
- Hits         35111    33906    -1205     
+ Misses        5841     5342     -499     
+ Partials      1788     1760      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit f9cdb5a into develop Oct 4, 2024
30 checks passed
@jmartinesp jmartinesp deleted the misc/disable-configuration-cache-in-ci branch October 4, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants