Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore only m.direct room entry to non-existing room instead of ignoring all #3659

Closed
spaetz opened this issue Oct 11, 2024 · 2 comments
Closed

Comments

@spaetz
Copy link

spaetz commented Oct 11, 2024

I suffered from an empty "Persons" tab ( (EXA 0.7). Examining the account m.direct data, the json validated just fine and it did NOT contain obvious non-sense such as "[object Object]" (see issue #3074), but it might have contained entries to rooms that do not exist any longer.
I emptied the m.direct data and repopulated it using EW and the /converttodm feature and now all people show correctly under the people's tab.

This issue is about making EXA (or the Rust SDK) simply ignoring invalid entries to rooms that do not exist rather than ignoring everything in case one of the entries seems invalid.

There is an additional task about whether synapse should clean up useless m.direct entries or whether EXA (Rust SDK?) should be doing the cleaning up? But that is an additional followup :-).

Originally posted by @spaetz in #3074 (comment)

@spaetz spaetz changed the title Ignore non-existing m.direct room entries instead of ignoring all Ignore only non-existing m.direct room entry instead of ignoring all Oct 11, 2024
@spaetz spaetz changed the title Ignore only non-existing m.direct room entry instead of ignoring all Ignore only m.direct room entry to non-existing room instead of ignoring all Oct 11, 2024
@bmarty
Copy link
Member

bmarty commented Oct 14, 2024

Rooms must stay listed in m.direct even if the user leave them. In case user is invited again, the room still have to be seen as a DM.

Creating the issue to the Rust SDK project as I believe this is where the fix has to be located.

@spaetz
Copy link
Author

spaetz commented Oct 18, 2024

OK, experimented with my m.direct data, and added non-existing rooms and/or user names. And even after deleting the cache, EXA worked fine, showing all persons in the persons tab. So, I have to conclude that my m.direct json was somehow corrupted in subtle ways and will close this issue. Will reopen a new one in the Rust SDK if I ever re-encounter this. Sorry for the noise.

@spaetz spaetz closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants