-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore only m.direct room entry to non-existing room instead of ignoring all. #4125
Comments
Are we sure this isn't a problem with the direct room data being malformed somehow? We've had some history of whole JSON lists/objects being discarded because serde couldn't deserialize part of them, and AFAICT the code that processes direct rooms will just add the flag to rooms matching some ids, remove it from the rest and skip any room that it can't find. |
@spaetz do you have more input to provide to help investigating this issue? |
Will do some tests and report back here. can take a few days though. What I can say is the the m.direct data validated fine using a json validator and nothing stood out. Will report after some tests. |
OK, experimented with my m.direct data, and added non-existing rooms and/or user names. And even after deleting the cache, EXA worked fine, showing all persons in the persons tab. So, I have to conclude that my m.direct json was somehow corrupted in subtle ways and will close this issue. Will reopen a new one in the Rust SDK if I ever re-encounter this. Sorry for the noise. P.S. please close this issue, I don't have the permission to do so :-) |
Initially created at element-hq/element-x-android#3659, but I believe that the fix has to be done here (or in Ruma?)
The text was updated successfully, but these errors were encountered: