Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore only m.direct room entry to non-existing room instead of ignoring all. #4125

Closed
bmarty opened this issue Oct 14, 2024 · 4 comments
Closed

Comments

@bmarty
Copy link
Contributor

bmarty commented Oct 14, 2024

Initially created at element-hq/element-x-android#3659, but I believe that the fix has to be done here (or in Ruma?)

@jmartinesp
Copy link
Contributor

Are we sure this isn't a problem with the direct room data being malformed somehow? We've had some history of whole JSON lists/objects being discarded because serde couldn't deserialize part of them, and AFAICT the code that processes direct rooms will just add the flag to rooms matching some ids, remove it from the rest and skip any room that it can't find.

@bmarty
Copy link
Contributor Author

bmarty commented Oct 16, 2024

@spaetz do you have more input to provide to help investigating this issue?

@spaetz
Copy link

spaetz commented Oct 16, 2024

Will do some tests and report back here. can take a few days though. What I can say is the the m.direct data validated fine using a json validator and nothing stood out. Will report after some tests.

@spaetz
Copy link

spaetz commented Oct 18, 2024

OK, experimented with my m.direct data, and added non-existing rooms and/or user names. And even after deleting the cache, EXA worked fine, showing all persons in the persons tab. So, I have to conclude that my m.direct json was somehow corrupted in subtle ways and will close this issue. Will reopen a new one in the Rust SDK if I ever re-encounter this. Sorry for the noise.

P.S. please close this issue, I don't have the permission to do so :-)

@jmartinesp jmartinesp closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants