Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove the “Quote” action from the menu of the selected message. #7713

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Nov 21, 2023

This PR fixes #7691 by removing the Quote action from the menu of the selected message.

@nimau nimau requested review from a team and Velin92 and removed request for a team November 21, 2023 13:58
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d088e98) 6.22% compared to head (b2e25fa) 12.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7713      +/-   ##
===========================================
+ Coverage     6.22%   12.37%   +6.15%     
===========================================
  Files         1648     1650       +2     
  Lines       163906   163915       +9     
  Branches     66329    66403      +74     
===========================================
+ Hits         10204    20289   +10085     
+ Misses      153260   142959   -10301     
- Partials       442      667     +225     
Flag Coverage Δ
uitests 55.02% <ø> (?)
unittests 6.20% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimau nimau merged commit 611b604 into develop Nov 22, 2023
13 checks passed
@nimau nimau deleted the nicolasm/PSB-427_remove-quote-menu-action branch November 22, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quotes are not working when the new WYSIWYG is enabled
2 participants