Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(main): add 2024 apple specs #1022

Merged
merged 2 commits into from
Oct 26, 2024
Merged

feat(main): add 2024 apple specs #1022

merged 2 commits into from
Oct 26, 2024

Conversation

onderceylan
Copy link
Collaborator

No description provided.

@nathanchase
Copy link
Contributor

Any progress on this? What's causing the failures?

@onderceylan onderceylan changed the title feat: add 2024 apple specs feat(main): add 2024 apple specs Oct 26, 2024
@onderceylan onderceylan merged commit b7714a1 into master Oct 26, 2024
8 checks passed
@onderceylan onderceylan deleted the feat/add-2024-specs branch October 26, 2024 17:35
@onderceylan
Copy link
Collaborator Author

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@onderceylan
Copy link
Collaborator Author

It should be good now @nathanchase, do you mind giving a test?

@nathanchase
Copy link
Contributor

I'm still seeing:

getSplashScreenMetaData Error: Evaluation failed: TypeError: Cannot read properties of undefined (reading 'querySelectorAll')
    at scrapeSplashScreenDataFromHIGPage (__puppeteer_evaluation_script__:5:145)
    at __puppeteer_evaluation_script__:49:16 😭`

@onderceylan
Copy link
Collaborator Author

@nathanchase this is fixed on version 6.4.0. You need to run the command on the latest version. Which version are you using? You can see it with pwa-asset-generator --version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants