Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper fix for Rails 4.2 #27

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Proper fix for Rails 4.2 #27

wants to merge 37 commits into from

Conversation

schuylr
Copy link

@schuylr schuylr commented Aug 20, 2015

This fixes the issues raised in Rails 4.2 and preserves the correct :enum type and symbol return values, due to the refactoring of column type declaration in 4.2

HonoreDB and others added 30 commits June 26, 2013 21:22
@HonoreDB
Avoid typecasting unexpected strings to symbols to prevent DoS due to…
a08246f 
… memory leak
@HonoreDB
Slight code cleanup
be82807
@HonoreDB
Assume ownership, update README
3ca204e
@mtanasie
Merge pull request #1 from mdsol/develop
0d6797e 
Assume ownership, update README
@HonoreDB
Rename initializer file to match new gem name
cbca08a
@agodel
makes compatible with Mysql2SpatialAdapter
8ffa96e
@agodel
makes gem compatible with mysql2spatial adapter
01be142
@agodel
removes commented code
3ae9184
@HonoreDB
Merge pull request #2 from mdsol/compatible_with_spatial_adapter
04f27ba 
Compatible with spatial adapter
@HonoreDB
Merge pull request #3 from mdsol/develop
a25508b 
Merge develop to master
@stanimal
V0.1.5: Move alias statements to after method definitions
b59ec1d
Revert alias lines being moved
ec80e81
Fixes and compatability with Rails 4.2
a760013
Update version
504730c
Backwards compatability for Rails 4.1
8dd883a
Prevent aliasing of initialize_type_map on older Rails versions
074d852
Protect type_cast_from_database from bc breaks
c98e7ec
Situational method declaration based on Rails versions
64f2552
Restore simplified_type
c3f51a0
See if method_defined is more reliable
afd4e47
Turns out that instance_methods and private_instance_methods are the …
bf6e15d 
…reliable way to do it
Must not forget about forwards compatability
0088bb1
Add parameter to type_cast_for_database
00e451e
@stanimal
Bump to 0.1.7: Fix mapping of nil value for enum
b269e21
v0.1.8: Fix default value not returning as a symbol
0e5bea9
Version bump the gemspec to 0.1.8
7f426ca
Add new adapter name and bump gemspec
9b29aff
Remove klass alias and method as Rails5 seems to have deprecated it
96dcebf
Bump gemspec to 5.0.0
2e7d879
Remove second argument in enum_column quoting for Rails 5.1
ebffc00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schuylr @HonoreDB @mtanasie @agodel @stanimal