Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: types/node upgrade #2019

Merged
merged 3 commits into from
Jul 19, 2024
Merged

chore: types/node upgrade #2019

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab9de53
chore: types/node upgrade
Jun 14, 2024
322bae5
chore: changefiles
Jul 19, 2024
3d5a0ba
chore: changefiles
Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,367 changes: 1,674 additions & 1,693 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/webpack-config-composer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.1",
"@types/chai": "^4.2.14",
"@types/mocha": "^10.0.1",
"@types/node": "^14.14.16",
"@types/node": "^20.14.10",
"@types/sinon": "^9.0.10",
"@types/sinon-chai": "^3.2.5",
"@typescript-eslint/eslint-plugin": "^4.11.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-app-dev/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.2",
"@types/chai": "^4.3.1",
"@types/mocha": "^10.0.1",
"@types/node": "^14.14.16",
"@types/node": "^20.14.10",
"@types/sinon": "^9.0.10",
"@types/sinon-chai": "^3.2.8",
"@types/webpack": "5.28.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-app-dev/src/lib/app-dev-middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export class AppDevMiddleware {
}

setup({ serverPort = undefined } = {}) {
process.on("message", data => {
process.on("message", (data: any) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets define this a bit more?

type ProcessDataIncoming = {
  name: string;
  [x: string | symbol | number]: unknown;
}
    process.on("message", (data: ProcessDataIncoming) => {

or inline...

    process.on("message", (data: { name: string; [x: string | symbol | number]: unknown; }) => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Let me create a PR 👍

switch (data.name) {
case WEBPACK_EVENT_REPORT:
this.handleWebpackReport(data);
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-app-dev/src/lib/dev-admin/redbird-spawn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const handleRestart = (type) => {
};

process.on("SIGHUP", restart);
process.on("message", (data) => {
process.on("message", (data: any) => {
if (data.name === "restart") {
restart(_.omit(data, "name"));
} else if (data.name === "update-ports") {
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.2",
"@types/chai": "^4.3.1",
"@types/mocha": "^10.0.1",
"@types/node": "^17.0.31",
"@types/node": "^20.14.10",
"@types/sinon": "^10.0.11",
"@types/sinon-chai": "^3.2.8",
"@typescript-eslint/eslint-plugin": "7.10.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-create-app/template/_package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ module.exports = (base, merge) => {
"@xarc/react-redux": "^1.0.0", // version will come from ../package.json
},
devDependencies: {
"@types/node": "^14.14.6",
"@types/node": "^20.14.10",
"@xarc/app-dev": "^11.0.0", // version will come from ../package.json
"@xarc/opt-postcss": "^2.0.0",
"@xarc/opt-stylus": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-dev-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"license": "Apache-2.0",
"devDependencies": {
"@istanbuljs/nyc-config-typescript": "^1.0.1",
"@types/node": "^14.14.16",
"@types/node": "^20.14.10",
"@typescript-eslint/eslint-plugin": "^4.11.0",
"@typescript-eslint/parser": "^4.11.0",
"@xarc/module-dev": "^4.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-index-page/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.2",
"@types/chai": "^4.3.16",
"@types/mocha": "^10.0.6",
"@types/node": "^20.12.12",
"@types/node": "^20.14.10",
"@types/sinon": "^17.0.3",
"@types/sinon-chai": "^3.2.12",
"@typescript-eslint/eslint-plugin": "7.10.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-jsx-renderer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.1",
"@types/chai": "^4.2.11",
"@types/mocha": "^10.0.1",
"@types/node": "^13.7.6",
"@types/node": "^20.14.10",
"@types/sinon": "^9.0.0",
"@types/sinon-chai": "^3.2.4",
"@typescript-eslint/eslint-plugin": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-react-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@testing-library/react": "^11.2.3",
"@types/chai": "^4.3.1",
"@types/mocha": "^10.0.1",
"@types/node": "^18.0.0",
"@types/node": "^20.14.10",
"@types/react": "^18.0.27",
"@types/react-dom": "^18.0.5",
"@types/sinon": "^10.0.11",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-react-recoil/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@testing-library/react": "^11.2.5",
"@types/chai": "^4.2.14",
"@types/mocha": "^10.0.1",
"@types/node": "^14.14.16",
"@types/node": "^20.14.10",
"@types/react": ">=18",
"@types/react-dom": ">=18",
"@types/sinon": "^9.0.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-react-redux-observable/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.1",
"@types/chai": "^4.2.14",
"@types/mocha": "^10.0.1",
"@types/node": "^14.14.16",
"@types/node": "^20.14.10",
"@types/react": "^18.0.4",
"@types/react-dom": "^18.0.4",
"@types/sinon": "^9.0.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-react-redux-saga/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.1",
"@types/chai": "^4.2.14",
"@types/mocha": "^10.0.1",
"@types/node": "^14.14.16",
"@types/node": "^20.14.10",
"@types/react": "^18.0.4",
"@types/react-dom": "^18.0.4",
"@types/sinon": "^9.0.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-react-redux/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@testing-library/react": "^13.2.0",
"@types/chai": "^4.3.1",
"@types/mocha": "^10.0.1",
"@types/node": "^18.11.9",
"@types/node": "^20.14.10",
"@types/react": "^18.0.4",
"@types/react-dom": "^18.0.4",
"@types/sinon": "^10.0.11",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-react-router/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@testing-library/react": "^13.2.0",
"@types/chai": "^4.3.1",
"@types/mocha": "^10.0.1",
"@types/node": "^18.11.9",
"@types/node": "^20.14.10",
"@types/react": "^18.0.9",
"@types/react-dom": "^18.0.5",
"@types/sinon": "^10.0.11",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.2",
"@types/chai": "^4.3.1",
"@types/mocha": "^10.0.1",
"@types/node": "^18.11.9",
"@types/node": "^20.14.10",
"@types/react": "^18.0.27",
"@types/react-dom": "^18.0.4",
"@types/sinon": "^10.0.11",
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-render-context/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.1",
"@types/chai": "^4.2.11",
"@types/mocha": "^10.0.1",
"@types/node": "^13.7.6",
"@types/node": "^20.14.10",
"@types/sinon": "^9.0.0",
"@types/sinon-chai": "^3.2.4",
"@typescript-eslint/eslint-plugin": "^5.25.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/xarc-subapp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@types/chai": "^4.2.14",
"@types/chai-as-promised": "^7.1.3",
"@types/mocha": "^10.0.1",
"@types/node": "^14.14.16",
"@types/node": "^20.14.10",
"@types/sinon": "^9.0.10",
"@types/sinon-chai": "^3.2.5",
"@typescript-eslint/eslint-plugin": "^4.11.0",
Expand All @@ -74,7 +74,7 @@
"sinon-chai": "^3.5.0",
"source-map-support": "^0.5.19",
"ts-node": "^10.9.1",
"typedoc": "^0.25.13",
"typedoc": "^0.26.3",
"typescript": "^5.4.5",
"xsh": "^0.4.5"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/xarc-tag-renderer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.1",
"@types/chai": "^4.2.11",
"@types/mocha": "^10.0.1",
"@types/node": "^13.7.6",
"@types/node": "^20.14.10",
"@types/sinon": "^9.0.0",
"@types/sinon-chai": "^3.2.4",
"@typescript-eslint/eslint-plugin": "^2.21.0",
Expand All @@ -41,8 +41,8 @@
"sinon-chai": "^3.3.0",
"source-map-support": "^0.5.16",
"ts-node": "^10.9.1",
"typedoc": "^0.25.13",
"typescript": "^5.4.5",
"typedoc": "^0.26.3",
"typescript": "^5.5.3",
"xsh": "^0.4.5",
"xstdout": "^0.1.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/xarc-tag-renderer/src/render-execute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const {
STEP_SUB_TEMPLATE
} = executeSteps;

function handleSubTemplate(tkId: string, step, result: any, xt: any, cb: Function) {
function handleSubTemplate(tkId: string, step, result: any, xt: any, cb: any) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we type param #2 (step) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't want to use Function (okay, it's frowned upon) .. lets define it a bit more

type callback = (...args: any) => void;
function handleSubTemplate(tkId: string, step, result: any, xt: any, cb: callback) {

or inline...

function handleSubTemplate(tkId: string, step, result: any, xt: any, cb: (...args: any) => void) {

also - could add some return types to the function's signature ..

if (!result) {
return cb();
}
Expand Down
3 changes: 2 additions & 1 deletion packages/xarc-webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"webpack-cli": "4.8.0",
"webpack-config-composer": "^1.2.2",
"webpack-stats-plugin": "^1.0.3",
"webpack-sources": "^2.3.1",
"xsh": "^0.4.5"
},
"peerDependencies": {
Expand All @@ -65,7 +66,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.2",
"@types/chai": "^4.3.1",
"@types/mocha": "10.0.0",
"@types/node": "^18.11.9",
"@types/node": "^20.14.10",
"@types/sinon": "^9.0.0",
"@types/sinon-chai": "^3.2.4",
"@typescript-eslint/eslint-plugin": "^2.21.0",
Expand Down
1 change: 0 additions & 1 deletion packages/xarc-webpack/src/partials/entry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ function makeEntryPartial() {
reducerHmrCode = `
import { getReduxCreateStore } from "subapp-redux";
import reducers from "${subAppReducers}";

if (subApp.reduxReducers && (!subApp.reduxCreateStore || subApp._genReduxCreateStore)) {
subApp._genReduxCreateStore = "hmr";
const createStore = getReduxCreateStore(subApp);
Expand Down
1 change: 0 additions & 1 deletion rush.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,5 @@
"shouldPublish": false,
"skipRushCheck": true
}

]
}
2 changes: 1 addition & 1 deletion samples/create-app-demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@xarc/react-redux": "^1.0.0"
},
"devDependencies": {
"@types/node": "^14.14.6",
"@types/node": "^20.14.10",
"@xarc/app-dev": "^11.0.0",
"@xarc/opt-postcss": "^2.0.0",
"@xarc/opt-stylus": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-component/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@istanbuljs/nyc-config-typescript": "^1.0.1",
"@types/chai": "^4.2.11",
"@types/mocha": "^7.0.2",
"@types/node": "^13.7.6",
"@types/node": "^20.14.10",
"@types/react": "^16.9.50",
"@types/react-dom": "^16.9.8",
"@types/sinon": "^9.0.0",
Expand Down
2 changes: 1 addition & 1 deletion samples/subapp2-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@module-federation/concat-runtime": "~0.0.1"
},
"devDependencies": {
"@types/node": "^20.4.9",
"@types/node": "^20.14.10",
"@xarc/run": "^1.1.1",
"prettier": "^3.0.1",
"ts-node": "^10.9.1",
Expand Down
2 changes: 1 addition & 1 deletion samples/subapp2-poc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

},
"devDependencies": {
"@types/node": "^20.2.5",
"@types/node": "^20.14.10",
"@xarc/run": "^1.1.1",
"@xarc/app-dev": "^11.0.9",
"@xarc/opt-eslint": "^3.0.1",
Expand Down
2 changes: 1 addition & 1 deletion samples/subapp2-react-query-todoapp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@xarc/react-query": "^0.1.0"
},
"devDependencies": {
"@types/node": "^14.14.6",
"@types/node": "^20.14.10",
"@xarc/app-dev": "^8.2.4",
"classnames": "^2.2.6",
"ts-node": "^9.0.0",
Expand Down
2 changes: 1 addition & 1 deletion samples/subapp2-store/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"recoil": "^0.1.2"
},
"devDependencies": {
"@types/node": "^14.14.6",
"@types/node": "^20.14.10",
"@xarc/app-dev": "^8.1.8",
"@xarc/opt-eslint": "^1.0.0",
"@xarc/opt-postcss": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion samples/subapp2-todo-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@xarc/react-redux": "^0.1.0"
},
"devDependencies": {
"@types/node": "^14.14.6",
"@types/node": "^20.14.10",
"@xarc/app-dev": "^8.2.0",
"classnames": "^2.2.6",
"ts-node": "^9.0.0",
Expand Down
Loading