feat: expose subapp root to provide better lifecycle control for applications #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylejeske
reviewed
Apr 18, 2024
| }); | ||
|
|
||
| expect(element.innerHTML).to.equal(""); | ||
| }); |
There was a problem hiding this comment.
Does it make sense to add a use case where the server content is mismatched from the client's content?
https://react.dev/reference/react-dom/client/hydrateRoot#caveats
There was a problem hiding this comment.
@kylejeske Hydration itself is already implemented, so probably that should be on a different PR.
This specifically was to test the enhancement to expose root and then app could do some lifecycle management. (line 114)
There was a problem hiding this comment.
Also, if there is a mismatch from server content, react itself would show warning and application need to fix that first before they use root for unmount IMO.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In React 18, unmountComponentAtNode was replaced by root.unmount().
Reference: https://react.dev/reference/react-dom/unmountComponentAtNode#unmountcomponentatnode
To accommodate this update, this PR modifies the implementation to expose the
rootobject. By doing so, it enables applications built with SubappV1 to leverageroot.unmount()for managing component lifecycles more effectively.