Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fixing stats error on initial load #1999

Merged
merged 6 commits into from
Jan 3, 2024
Merged

feat: fixing stats error on initial load #1999

merged 6 commits into from
Jan 3, 2024

Conversation

shubham2811
Copy link
Contributor

@shubham2811 shubham2811 commented Nov 30, 2023 •
edited by arunvishnun
Loading

Summary

Fixing stats error on initial dev server start up
image-2023-03-27-14-23-53-064

@arunvishnun arunvishnun marked this pull request as ready for review December 7, 2023 14:48
@arunvishnun arunvishnun requested a review from a team as a code owner December 7, 2023 14:48
kylejeske
kylejeske previously requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@kylejeske kylejeske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the until function if conditionals could use some formatting to bring it in with the standards.

You might be able to simplify that by just returning the new promise rather than setting a one time use constant.

Otherwise, LGTM.

@arunvishnun arunvishnun dismissed kylejeske’s stale review January 3, 2024 22:38

Review suggestions addressed, since you are out on vacation, dismissing to unblock

@arunvishnun arunvishnun self-requested a review January 3, 2024 22:42
@arunvishnun arunvishnun merged commit 55072c1 into electrode-io:master Jan 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuthya smuthya smuthya approved these changes

@kylejeske kylejeske kylejeske left review comments

@arunvishnun arunvishnun Awaiting requested review from arunvishnun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubham2811 @kylejeske @arunvishnun @smuthya