Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all! Thank you all so much for maintaining so many wonderful open source tools.
I have a project which is built using cmake and has the DaisySP repo as a submodule. I was super excited to try out reverbsc from DaisySP-LGPL. I added the dependency as follows
However, I ran into an error when trying to build
When I looked into it a bit more, it seems like the
CmakeLists.txt
is reaching too far back, and I was able to fix the issue with the following changes