Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial scaffolding for open source QA layer #4226

Merged

Conversation

FelixDQ
Copy link
Member

@FelixDQ FelixDQ commented Jun 8, 2022

This adds the initial setup for adding validation rules. Validation rules can be added by adding a new function in ./validators.

Validation rules need the decorator function @validator to specify what kind of data the rule supports (i.e. which data types or potentially zones).

The function itself should specify in the parameters which external data it needs to perform the validation. Right now it only supports the events themselves, but in the future, they will also be able to request things like yearly means and surrounding events to detect outliers for example.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 8, 2022
@FelixDQ FelixDQ marked this pull request as draft June 8, 2022 13:28
@FelixDQ FelixDQ marked this pull request as ready for review June 8, 2022 14:03
@FelixDQ FelixDQ requested a review from pierresegonne June 8, 2022 14:03
Copy link
Member

@pierresegonne pierresegonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo!

@FelixDQ FelixDQ merged commit c008425 into master Jun 8, 2022
@FelixDQ FelixDQ deleted the felixqvist/ele-1057-integrate-evaluation-with-open-source branch June 8, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants