Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode compatible hyperlinks in terminal output for compilation errors #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deldrid1
Copy link

@ppetrosh - this PR provides an update that allows for impt build run squirrel compilation errors to be clickable in VSCode via <path>:<line>:<column> syntax ala https://code.visualstudio.com/updates/v1_12#_integrated-terminal-link-line-and-column-ranges. This makes the errors much more useful/productive as you don't have to go chase them down in code.

screenshot 2018-07-12 09 20 02

This is just a simple proof of concept that should be extended properly - not being familiar with Yargs, this code base is a bit tough for me to navigate as far as development goes, but hopefully this gives you enough of an idea of what would need to happen to pull it in?

In a future state, this would actually link you to the builder source files in addition to the built file - I'm hoping your much more familiar with the structure of the impt code base and thats something you could add!

@ppetrosh
Copy link
Contributor

Thank you @deldrid1! I'll grab it from here.

I would also like to hear more about your best practices of developing EI projects in the VS Code. Are there any tricks that you can share? I would like to make it an officially supported/recommended option to the Sublime Text Plugin.

@deldrid1
Copy link
Author

Probably would be best to setup a phone call? Do you want to reach out via email?

As a high level comment, I would love for VSCode to be an officially supported first-party “thick” client solution with full impCentral UI capability, plus more! I think between imp-central-api, imp-central-impt, Builder, and the impCentral web page, most of the hooks are already there....

In case you get bored:
https://code.visualstudio.com/docs/extensions/webview
https://code.visualstudio.com/docs/extensions/samples
https://github.com/Microsoft/vscode-extension-samples/tree/master/tree-view-sample

@ppetrosh
Copy link
Contributor

Yes, definitely let's discuss this! Thanks, @deldrid1

@ppetrosh
Copy link
Contributor

As we have vscode extension implemented, is this still relevant?

@ppetrosh
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants