-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Understand welkin #1015
Understand welkin #1015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, added some nits and a few comments.
Something I am missing is perhaps to mention that Welkin apps is built on Helmfile and that our configuration files are used to configure the Helm charts that we have as part of our Helmfile stack(s).
Co-authored-by: anders-elastisys <[email protected]>
Co-authored-by: anders-elastisys <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work so far! Added a bunch of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great start for explaining how all of this works and is set up. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to see some changes, see comments, but in general, I definitely approve of this!
Co-authored-by: Albin Björk <[email protected]>
Co-authored-by: Lars Larsson <[email protected]>
Quality gates:
While drafting an operations manual for a customer, we realized that we don't really have for the platform administrator a page which describes the "forest" before describing the "trees". This PR bridges this gap.