Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the EMS section in the air-gapped documentation #2658

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

jsanz
Copy link
Member

@jsanz jsanz commented Jan 26, 2024

Related to elastic/kibana#175551

This is a small edit in the EMS section to link to the full document and explain better the three options available to users regarding the product in air-gapped environments.

cc. @nreese

@jsanz jsanz requested a review from a team as a code owner January 26, 2024 11:48
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Jan 26, 2024

This pull request does not have a backport label. Could you fix it @jsanz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

kilfoyle
kilfoyle previously approved these changes Jan 26, 2024
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Thanks a lot for adding this @jsanz. I've added a label so that this backports into the current, 8.12 docs.

@jsanz
Copy link
Member Author

jsanz commented Jan 26, 2024

Thanks, @kilfoyle; I don't have permission to add labels or merge, so please could you merge it?

@kilfoyle
Copy link
Contributor

@jsanz, Sure, I'll be happy to merge and backport it. Just let me know when it's ready (as I assume you'll want to add in Nathan's suggestion).

@jsanz
Copy link
Member Author

jsanz commented Jan 26, 2024

@jsanz, Sure, I'll be happy to merge and backport it. Just let me know when it's ready (as I assume you'll want to add in Nathan's suggestion).

PR is ready, @kilfoyle; thanks for the support!

@kilfoyle kilfoyle merged commit 6cf4ee4 into elastic:main Jan 26, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 26, 2024
* Update air-gapped-install.asciidoc

* feedback

(cherry picked from commit 6cf4ee4)
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making these changes.

@jsanz jsanz deleted the patch-1 branch January 26, 2024 16:50
kilfoyle pushed a commit that referenced this pull request Jan 26, 2024
* Update air-gapped-install.asciidoc

* feedback

(cherry picked from commit 6cf4ee4)

Co-authored-by: Jorge Sanz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.12 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants