Improve rolling upgrade order docs #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first point in the list (upgrade the master-ineligible nodes) is redundant and sort of contradicts the second one (upgrade the data nodes tier-by-tier). This commit drops it. The second point had some redundant sentences in a somewhat awkward order. This commit cleans that up. There's no mention of nodes that are neither data nodes nor master-eligible nodes. In fact it doesn't really matter when these nodes are upgraded, but this commit specifies to upgrade them before the master-eligible nodes for the sake of completeness. Finally, there were some over-long lines so this commit reflows the source.
DaveCTurner
added
v8.10
backport-8.10
|
Documentation preview: |
|
Not sure about the labelling policy in this repo but my intention is for this to go into the current live docs (8.10) and future versions (8.11 and beyond). |
abdonpijpelink
approved these changes
Oct 19, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
The first point in the list (upgrade the master-ineligible nodes) is redundant and sort of contradicts the second one (upgrade the data nodes tier-by-tier). This commit drops it. The second point had some redundant sentences in a somewhat awkward order. This commit cleans that up. There's no mention of nodes that are neither data nodes nor master-eligible nodes. In fact it doesn't really matter when these nodes are upgraded, but this commit specifies to upgrade them before the master-eligible nodes for the sake of completeness. Finally, there were some over-long lines so this commit reflows the source. (cherry picked from commit d401cda)
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
The first point in the list (upgrade the master-ineligible nodes) is redundant and sort of contradicts the second one (upgrade the data nodes tier-by-tier). This commit drops it. The second point had some redundant sentences in a somewhat awkward order. This commit cleans that up. There's no mention of nodes that are neither data nodes nor master-eligible nodes. In fact it doesn't really matter when these nodes are upgraded, but this commit specifies to upgrade them before the master-eligible nodes for the sake of completeness. Finally, there were some over-long lines so this commit reflows the source. (cherry picked from commit d401cda)
DaveCTurner
added a commit
that referenced
this pull request
Oct 19, 2023
The first point in the list (upgrade the master-ineligible nodes) is redundant and sort of contradicts the second one (upgrade the data nodes tier-by-tier). This commit drops it. The second point had some redundant sentences in a somewhat awkward order. This commit cleans that up. There's no mention of nodes that are neither data nodes nor master-eligible nodes. In fact it doesn't really matter when these nodes are upgraded, but this commit specifies to upgrade them before the master-eligible nodes for the sake of completeness. Finally, there were some over-long lines so this commit reflows the source. (cherry picked from commit d401cda) Co-authored-by: David Turner <[email protected]>
DaveCTurner
added a commit
that referenced
this pull request
Oct 19, 2023
The first point in the list (upgrade the master-ineligible nodes) is redundant and sort of contradicts the second one (upgrade the data nodes tier-by-tier). This commit drops it. The second point had some redundant sentences in a somewhat awkward order. This commit cleans that up. There's no mention of nodes that are neither data nodes nor master-eligible nodes. In fact it doesn't really matter when these nodes are upgraded, but this commit specifies to upgrade them before the master-eligible nodes for the sake of completeness. Finally, there were some over-long lines so this commit reflows the source. (cherry picked from commit d401cda) Co-authored-by: David Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first point in the list (upgrade the master-ineligible nodes) is
redundant and sort of contradicts the second one (upgrade the data nodes
tier-by-tier). This commit drops it.
The second point had some redundant sentences in a somewhat awkward
order. This commit cleans that up.
There's no mention of nodes that are neither data nodes nor
master-eligible nodes. In fact it doesn't really matter when these nodes
are upgraded, but this commit specifies to upgrade them before the
master-eligible nodes for the sake of completeness.
Finally, there were some over-long lines so this commit reflows the
source.