Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes URLs in OOTB security jobs and updates job IDs #2563

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Oct 13, 2023

Overview

Related to #2562.

This PR:

  • removes the Job and Datafeed columns from the tables under Security: Elastic integrations section. Reason: Updates to integration packages are frequent and hard to maintain the URLs.
  • adds a link to the job and datafeed config files after each table.

Scope: 8.9 and above.

Source of information

@szabosteve szabosteve added :ml v8.9.0 backport-8.9 Automated backport with mergify v8.10 backport-8.10 Automated backport with mergify v8.11 backport-8.11 Automated backport with mergify v8.12 labels Oct 13, 2023
@szabosteve szabosteve requested a review from ajosh0504 October 13, 2023 10:30
@github-actions
Copy link

Documentation preview:

@ajosh0504
Copy link

Actually while we're here, can we get rid of Job and Datafeed links for these jobs? These might get updated frequently so pointing to specific line numbers might become hard to maintain. After the text To download, refer to the documentation for each of the integrations, we can say something like:

The Anomaly Detection jobs associated with this integration are as follows:

<Table of Job Name | Description>

The job configurations and datafeeds can be found [here](<link-to-config-file>).

link-to-config-file:

@szabosteve
Copy link
Contributor Author

@ajosh0504 Sure, I updated the PR via ecc40d3.

Copy link

@ajosh0504 ajosh0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for this! 🚀

@szabosteve szabosteve merged commit 0d20ee9 into elastic:main Oct 16, 2023
1 check passed
@szabosteve szabosteve deleted the fix-link-ootb-security-jobs branch October 16, 2023 16:14
mergify bot pushed a commit that referenced this pull request Oct 16, 2023
mergify bot pushed a commit that referenced this pull request Oct 16, 2023
mergify bot pushed a commit that referenced this pull request Oct 16, 2023
szabosteve added a commit that referenced this pull request Oct 17, 2023
(cherry picked from commit 0d20ee9)

Co-authored-by: István Zoltán Szabó <[email protected]>
szabosteve added a commit that referenced this pull request Oct 17, 2023
(cherry picked from commit 0d20ee9)

Co-authored-by: István Zoltán Szabó <[email protected]>
szabosteve added a commit that referenced this pull request Oct 17, 2023
(cherry picked from commit 0d20ee9)

Co-authored-by: István Zoltán Szabó <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify :ml v8.9.0 v8.10 v8.11 v8.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants