Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Adds v2 section to ELSER docs #2551

Merged
merged 8 commits into from
Oct 4, 2023
Merged

[DOCS] Adds v2 section to ELSER docs #2551

merged 8 commits into from
Oct 4, 2023

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Sep 27, 2023 •
edited
Loading

Overview

Related to: https://github.com/elastic/platform-docs-team/issues/206

This PR:

  • adds a new section to the ELSER docs about the improvements in ELSER v2,
  • moves the benchmark info under a subpage,
  • adds quantitative benchmark info for v2 compared to v1,
  • adds an info block about ELSER v2 not being backward compatible,
  • adds an admonition about retrieval accuracy and performance,
  • mentions that either rank_features or sparse_vector field type can be used,
  • updates the code snippets to refer to elser_model_2,
  • updates the screenshots to display elser_model_2 (all screenshots are affected).

Preview

ELSER

@github-actions
Copy link

Documentation preview:

@mergify mergify bot added the backport-skip Skip automated backport with mergify label Sep 27, 2023
@elastic elastic deleted a comment from mergify bot Sep 27, 2023
@szabosteve szabosteve removed the WIP Work in progress label Oct 3, 2023
@szabosteve szabosteve marked this pull request as ready for review October 3, 2023 14:17
@qherreros
Copy link

LGTM !

davidkyle
davidkyle approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szabosteve szabosteve enabled auto-merge (squash) October 4, 2023 15:52
@szabosteve szabosteve merged commit 8994088 into elastic:main Oct 4, 2023
1 check passed
@szabosteve szabosteve deleted the elser-v2 branch October 4, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

@qherreros qherreros Awaiting requested review from qherreros

Assignees
No one assigned
Labels
backport-skip Skip automated backport with mergify ELSER :ml nlp v8.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szabosteve @qherreros @davidkyle