Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of text similarity models to compatible NLP models #2548

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

davidkyle
Copy link
Member

Text similarity must use a cross encoder model which has caused some confusion

For elastic/elasticsearch#99211

@github-actions
Copy link

Documentation preview:

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

This pull request does not have a backport label. Could you fix it @davidkyle? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip automated backport with mergify label Sep 26, 2023
@davidkyle davidkyle added backport-8.10 Automated backport with mergify and removed backport-skip Skip automated backport with mergify labels Sep 26, 2023
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition! LGTM.

@davidkyle davidkyle merged commit 96f6c88 into elastic:main Sep 26, 2023
2 checks passed
@davidkyle davidkyle deleted the text_similarity_models branch September 26, 2023 11:00
mergify bot pushed a commit that referenced this pull request Sep 26, 2023
davidkyle added a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.10 Automated backport with mergify :ml nlp v8.10 v8.11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants