Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace/remove references to defunct freenode instance (#16873) #16897

Merged
merged 1 commit into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ supported platforms, from [downloads page](https://www.elastic.co/downloads/logs

- [Logstash Forum](https://discuss.elastic.co/c/logstash)
- [Logstash Documentation](https://www.elastic.co/guide/en/logstash/current/index.html)
- [#logstash on freenode IRC](https://webchat.freenode.net/?channels=logstash)
- [Logstash Product Information](https://www.elastic.co/products/logstash)
- [Elastic Support](https://www.elastic.co/subscriptions)

Expand Down
2 changes: 1 addition & 1 deletion lib/pluginmanager/templates/codec-plugin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Logstash provides infrastructure to automatically generate documentation for thi

## Need Help?

Need help? Try #logstash on freenode IRC or the https://discuss.elastic.co/c/logstash discussion forum.
Need help? Try the https://discuss.elastic.co/c/logstash discussion forum.

## Developing

Expand Down
2 changes: 1 addition & 1 deletion lib/pluginmanager/templates/filter-plugin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Logstash provides infrastructure to automatically generate documentation for thi

## Need Help?

Need help? Try #logstash on freenode IRC or the https://discuss.elastic.co/c/logstash discussion forum.
Need help? Try the https://discuss.elastic.co/c/logstash discussion forum.

## Developing

Expand Down
2 changes: 1 addition & 1 deletion lib/pluginmanager/templates/input-plugin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Logstash provides infrastructure to automatically generate documentation for thi

## Need Help?

Need help? Try #logstash on freenode IRC or the https://discuss.elastic.co/c/logstash discussion forum.
Need help? Try the https://discuss.elastic.co/c/logstash discussion forum.

## Developing

Expand Down
2 changes: 1 addition & 1 deletion lib/pluginmanager/templates/output-plugin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Logstash provides infrastructure to automatically generate documentation for thi

## Need Help?

Need help? Try #logstash on freenode IRC or the https://discuss.elastic.co/c/logstash discussion forum.
Need help? Try the https://discuss.elastic.co/c/logstash discussion forum.

## Developing

Expand Down
29 changes: 14 additions & 15 deletions logstash-core/lib/logstash/config/mixin.rb
Original file line number Diff line number Diff line change
Expand Up @@ -125,21 +125,20 @@ def config_init(params)
extra.gsub!("%PLUGIN%", self.class.config_name)
# Log to main logger in addition to deprecation logger, in the 9.x series
# we will remove the main logger and only use the deprecation logger
self.logger.warn("You are using a deprecated config setting " +
"#{name.inspect} set in #{self.class.config_name}. " +
"Deprecated settings will continue to work, " +
"but are scheduled for removal from logstash " +
"in the future. #{extra} If you have any questions " +
"about this, please visit the #logstash channel " +
"on freenode irc.", :name => name, :plugin => self)
self.deprecation_logger.deprecated("You are using a deprecated config setting " +
"#{name.inspect} set in #{self.class.config_name}. " +
"Deprecated settings will continue to work, " +
"but are scheduled for removal from logstash " +
"in the future. #{extra} If you have any questions " +
"about this, please visit the #logstash channel " +
"on freenode irc.", {})

self.logger.warn("You are using a deprecated config setting " \
"#{name.inspect} set in #{self.class.config_name}. " \
"Deprecated settings will continue to work, " \
"but are scheduled for removal from logstash " \
"in the future. #{extra} If you have any questions " \
"about this, please ask it on the " \
"https://discuss.elastic.co/c/logstash discussion forum", :name => name, :plugin => self)
self.deprecation_logger.deprecated("You are using a deprecated config setting " \
"#{name.inspect} set in #{self.class.config_name}. " \
"Deprecated settings will continue to work, " \
"but are scheduled for removal from logstash " \
"in the future. #{extra} If you have any questions " \
"about this, please ask it on the " \
"https://discuss.elastic.co/c/logstash discussion forum", {})
end

if opts && opts[:obsolete]
Expand Down
2 changes: 1 addition & 1 deletion logstash-core/spec/logstash/config/mixin_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
expect(main_logger).to receive(:warn).at_least(:once) do |arg1, arg2|
message = 'You are using a deprecated config setting "old_opt" set in test_deprecated. ' \
'Deprecated settings will continue to work, but are scheduled for removal from logstash in the future. ' \
'this is old school If you have any questions about this, please visit the #logstash channel on freenode irc.'
'this is old school If you have any questions about this, please ask it on the https://discuss.elastic.co/c/logstash discussion forum'
expect(arg1).to eq(message)
expect(arg2[:plugin].to_s).to include('"password"=><password>')
end
Expand Down
Loading