Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #16882 to 8.17: Validate the size limit in BufferedTokenizer. #16891

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2025

Backport PR #16882 to 8.17 branch, original message:


Release notes

[rn:skip]

What does this PR do?

Currently, BufferedTokenizer doesn't validate size limit. That means any negative or zero value can lead input buffer full exception. This PR adds a safeguard validation on size limit to allow only positive number.

Why is it important/What is the impact to the user?

As it is a public interface, this enhancement improves interface experience.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mashhurs mashhurs merged commit 5bd02d9 into 8.17 Jan 10, 2025
5 checks passed
@mashhurs mashhurs deleted the backport_16882_8.17 branch January 10, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants