Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add Java 21 option for multi JDK CI pipeline #15691

Merged
merged 2 commits into from
Dec 18, 2023
Merged

[ci] Add Java 21 option for multi JDK CI pipeline #15691

merged 2 commits into from
Dec 18, 2023

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Dec 13, 2023 •
edited
Loading

Release notes

[rn:skip]

What does this PR do?

Now that CI VM images are pre-provisioned with various flavors of Java 21, we add the option for the corresponding CI job.
Adoptium 17 remains the default pre-selected option.

Why is it important/What is the impact to the user?

This allows us to smoke test Logstash with Java 21.

How to test this PR locally

Just kick the BK job:

and use this PR, by setting pull/15691/merge in the branch field, and then select the desired Java 21 flavors.

Related issues

@dliappis
[ci] Add Java 21 option for multi JDK CI pipeline
1580e9f 
Now that CI VM images are pre-provisioned with various flavors of
Java 21, we add the option for the corresponding CI job.

Relates elastic/ci-agent-images#463
@dliappis dliappis added the ci label Dec 13, 2023
@dliappis dliappis self-assigned this Dec 13, 2023
@dliappis
Copy link
Contributor Author

Example build: https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/67#018c6282-0529-40c5-bef7-0b010c3d12df/46-114

we see failures (link):

* What went wrong:
Could not open settings generic class cache for settings file '/opt/buildkite-agent/builds/bk-agent-prod-gcp-1702459784445260434/elastic/logstash-linux-jdk-matrix-pipeline/settings.gradle' (/opt/buildkite-agent/.gradle/caches/7.5/scripts/3qic0xv3uo5z56h7411bzzlkd).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 65

@dliappis
Copy link
Contributor Author

buildkite test this

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @dliappis

@dliappis dliappis requested review from andsel and jsvd December 13, 2023 11:33
@dliappis dliappis marked this pull request as ready for review December 13, 2023 11:33
andsel
andsel approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis dliappis merged commit f062fef into elastic:main Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andsel andsel andsel approved these changes

@jsvd jsvd Awaiting requested review from jsvd

Assignees

@dliappis dliappis

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dliappis @elasticmachine @andsel @roaksoax