Added ability to specifiy filter worker threads #25
Conversation
|
Thanks a lot for your contribution @daph, I'm going to review this very soon. |
|
reviewing |
| #] | ||
| # | ||
| [ | ||
| {:workers => 2, :name => "simple line in/out", :config => "config/simple.conf", :input => "input/simple_10.txt", :time => 120}, |
There was a problem hiding this comment.
why having this example all using 2 workers? what is the reasoning behind it for you? thanks!
There was a problem hiding this comment.
not sure we need special examples, with workers, I Think we can provide this info by only having one example and good comments. What do you think?
There was a problem hiding this comment.
There's no real reason why the examples all use 2 workers. It's just more than one and most machines can easily handle 2 threads so I thought it was a decent example. I'm not opposed to changing it up though.
Yeah, you're right, we probably don't need special examples. Maybe just removing these with_workers examples all together and just changing a couple of the tests in the original example files to use workers.
There was a problem hiding this comment.
I like your way of thinking about the 2 workers, we should also add documentation for it.
There was a problem hiding this comment.
I would remove the with_workers examples and mix the workers config with the former examples. So we end up with some with workers option and some without.
|
@daph only small comments made, this looks great! as soon as your changes are done I'm happy to merge this! thanks a lot for your time. |
|
@purbon I've made changes based on your comments. Hopefully they are to your satisfaction. |
This change fixes issue #23
It adds the ability to (optionally) specify the amount of worker threads for each test in a suite, by adding
:workers => Nto the test. If it's not there, it defaults to 1 worker, which is what logstash does by default itself if you don't specify-wto it.