[8.17] [ResponseOps][Rules] Validate timezone in rule routes (#201508) #208299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary
This PR adds validation only for internal routes that use the `rRule`
schema.
## Testing
1. Create a rule in main.
2. Snooze the rule by using the API as
```
POST /internal/alerting/rule/<ruleId>/_snooze
{
"snooze_schedule": {
"id": "e58e2340-dba6-454c-8308-b2ca66a7cf7b",
"duration": 86400000,
"rRule": {
"dtstart": "2024-09-04T09:27:37.011Z",
"tzid": "invalid",
"freq": 2,
"interval": 1,
"byweekday": [
"invalid"
]
}
}
}
```
4. Go to the rules page and verify that the rules are not loaded.
5. Switch to my PR.
6. Go to the rules page and verify that the rules load.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
---------
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 9a3fc89)
# Conflicts:
# packages/kbn-rrule/validate.test.ts
# packages/kbn-rrule/validate.ts
# x-pack/packages/kbn-cloud-security-posture/common/types/graph/latest.ts
# x-pack/platform/plugins/shared/alerting/server/lib/snooze/is_snooze_active.test.ts
# x-pack/platform/plugins/shared/alerting/server/lib/snooze/is_snooze_active.ts
# x-pack/plugins/alerting/common/routes/r_rule/request/schemas/v1.ts
# x-pack/plugins/alerting/common/routes/r_rule/validation/index.ts
# x-pack/plugins/alerting/common/routes/r_rule/validation/validate_recurrence_by/v1.ts
# x-pack/plugins/alerting/server/application/rule/methods/snooze/snooze_rule.test.ts
# x-pack/plugins/alerting/server/lib/snooze/get_active_snooze_if_exist.test.ts
# x-pack/plugins/alerting/server/lib/snooze/get_active_snooze_if_exist.ts
# x-pack/plugins/alerting/server/lib/snooze/is_snooze_active.test.ts
# x-pack/plugins/alerting/server/lib/snooze/is_snooze_active.ts
# x-pack/plugins/triggers_actions_ui/tsconfig.json
1 task
|
Blocked by #208182. |
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation