Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vSphere] Add unique document id for all the data-streams #11534

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[vSphere] Add unique document id for all the data-streams #11534

wants to merge 7 commits into from

Conversation

kush-elastic
Copy link
Collaborator

  • Enhancement

Description

Add unique document id for all the data-streams

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@kush-elastic kush-elastic added enhancement New feature or request Integration:vsphere VMware vSphere labels Oct 28, 2024
@kush-elastic kush-elastic self-assigned this Oct 28, 2024
@kush-elastic kush-elastic marked this pull request as ready for review November 20, 2024 06:16
@kush-elastic kush-elastic requested a review from a team as a code owner November 20, 2024 06:16
@andrewkroh andrewkroh added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Nov 20, 2024
@elasticmachine
Copy link

elasticmachine commented Nov 21, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @kush-elastic

ishleenk17
ishleenk17 reviewed Nov 25, 2024
View reviewed changes
packages/vsphere/data_stream/cluster/fields/fields.yml
type: keyword
description: >
Unique cluster ID.
# Reason to add as a dimension field: to uniquely identify the cluster ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Reason to add as a dimension field: to uniquely identify the cluster ID.
# Added as a dimension field, to uniquely identify the cluster ID.

packages/vsphere/data_stream/datastore/fields/fields.yml
type: keyword
description: >
Unique datastore ID.
# Reason to add as a dimension field: to uniquely identify the datastore ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ame change as above

@muthu-mps
Copy link
Contributor

muthu-mps commented Dec 2, 2024 •
edited
Loading

Fixes the failing system tests reported in #11849, #11850, #11851, #11852, #11853, #11854, #11855

@muthu-mps muthu-mps mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 left review comments

@harnish-elastic harnish-elastic harnish-elastic approved these changes

@lucian-ioan lucian-ioan lucian-ioan approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

At least 1 approving review is required to merge this pull request.

Assignees

@kush-elastic kush-elastic

Labels
enhancement New feature or request Integration:vsphere VMware vSphere Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kush-elastic @elasticmachine @muthu-mps @lucian-ioan @ishleenk17 @harnish-elastic @andrewkroh