You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataStreamReindexTask currently hods onto lists of index names that are being processed. This is unnecessary for the status we are reporting, and overcomplicates things. This small cleanup PR changes those to counts instead. It also removes a no-longer-used ThreadPool reference.
How did we decide that the indices being affected aren't as important? (Just out of curiosity, not trying to undo this)
This information will be used for reporting the status of the persistent task. We're trying not to expose backing index information in status -- I think we (the upgrade assistant) would rather report it as how much of the data stream is complete, without ever mentioning index names. Also, if we were to report index names we'd need to record each completed index in the cluster state, which would add to the burden on the master node without buying us anything. This way we just record the total number at the beginning of the task, and can compute how many are pending or in progress or completed on the fly.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masseyke
added
>refactoring
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
DataStreamReindexTask currently hods onto lists of index names that are being processed. This is unnecessary for the status we are reporting, and overcomplicates things. This small cleanup PR changes those to counts instead. It also removes a no-longer-used ThreadPool reference.