Save duplicate REST client in ESRestTestCase #117910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I debugged some tests today and noticed that these two clients are the same in almost all cases, no need to use extra connections. Might give usa small speedup for these tests that tend to be quite slow relative to the node client based tests.
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
Thanks Mark! |
original-brownbear
added
the
auto-backport
💚 Backport successful
|
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 5, 2024
I debugged some tests today and noticed that these two clients are the same in almost all cases, no need to use extra connections. Might give usa small speedup for these tests that tend to be quite slow relative to the node client based tests.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 5, 2024
I debugged some tests today and noticed that these two clients are the same in almost all cases, no need to use extra connections. Might give usa small speedup for these tests that tend to be quite slow relative to the node client based tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I debugged some tests today and noticed that these two clients are the same in almost all cases, no need to use extra connections. Might give us a small speedup (from fewer context switches, tcp being tcp etc.) and saves precious ports/FDs/memory for these tests that tend to be quite slow relative to the node client based tests.