Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Response\Elasticsearch::offsetGet() return type declaration #1385

Conversation

AnnaNtagiou
Copy link
Contributor

Fixes #1384

@AnnaNtagiou AnnaNtagiou marked this pull request as draft November 30, 2023 15:29
@AnnaNtagiou AnnaNtagiou force-pushed the annantagiou/fix-offset-get-return-type-declaration branch from 146e37c to 3fc4907 Compare November 30, 2023 15:46
@AnnaNtagiou AnnaNtagiou force-pushed the annantagiou/fix-offset-get-return-type-declaration branch from 3fc4907 to 262086b Compare November 30, 2023 16:03
@AnnaNtagiou AnnaNtagiou marked this pull request as ready for review November 30, 2023 16:04
@AnnaNtagiou
Copy link
Contributor Author

@ezimuel can you approve the workflow please?

@AnnaNtagiou AnnaNtagiou changed the title Fix Response\Elasticsearch::offsetGet() return type declaration Fix Response\Elasticsearch::offsetGet() return type declaration Nov 30, 2023
@AnnaNtagiou
Copy link
Contributor Author

@ezimuel, thanks for approving the workflow! The CI is green. The failure is not related to my changes.

@ruudk
Copy link
Contributor

ruudk commented Dec 21, 2023

@ezimuel What's needed to get this merged and tagged? It would be great to silence the error reported by Symfony.

@AnnaNtagiou
Copy link
Contributor Author

@ezimuel, you are probably very busy, but could you please let me know what needs to be done to move this PR forward? Thanks

@ezimuel ezimuel merged commit fef964f into elastic:main Jan 25, 2024
6 of 7 checks passed
@ezimuel
Copy link
Contributor

ezimuel commented Jan 25, 2024

@AnnaNtagiou sorry for the delay, just merged. Thanks!

@ruudk
Copy link
Contributor

ruudk commented Jan 25, 2024

Thanks for merging it, will a tag follow soon as well? 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response\Elasticsearch::offsetGet() return type declaration
3 participants