[8.15](backport #5369) Add health_check extension to bundled otel.yml file
#5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Add health_check extension to bundled otel.yml file * Adding CHANGELOG * Add extension to pipeline Co-authored-by: Roger Coll <[email protected]> * Change path to health check endpoint * Revert change to health check endpoint path --------- Co-authored-by: Roger Coll <[email protected]> (cherry picked from commit 445fa44)
mergify
bot
requested review from
michel-laterman and
swiatekm
and removed request for
a team
|
ycombinator
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
health_checkextension to theotel.ymlfile that's bundled with the Elastic Agent package.Why is it important?
Without this addition, if a user tries to install the
open-telemetry/opentelemetry-collectorHelm chart with Elastic's distribution of the OTel Collector (i.e. Elastic Agent), the installation eventually fails. Specifically, as noted by @andrzej-stencel in #5092 (comment):Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testDisruptive User Impact
If users are already running something that's listening on
localhost:13133, there will be a port conflict.How to test this PR locally
See #5092 (comment) and #5092 (comment)
This is an automatic backport of pull request #5369 done by [Mergify](https://mergify.com).