Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable basic DRA qualifiers #3119

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Conversation

seanstory
Copy link
Member

@seanstory seanstory commented Jan 16, 2025

Part of https://github.com/elastic/search-team/issues/9111

This gives us the ability to specify a VERSION_QUALIFIER env var for a buildkite pipeline, and have that qualifier be picked up when producing staging artifacts.

After this PR is merged, we will trigger a build on main with VERSION_QUALIFIER=alpha1 to produce a 9.0.0-alpha1 pre-release for internal testing.

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • this PR has a thorough description
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes

@seanstory
Copy link
Member Author

I've confirmed that the outputs look right:


2025-01-16 15:57:25 CST | Contents of 'dra-artifacts' subdir
-- | --
  | 2025-01-16 15:57:25 CST | ++ ls -lah /opt/buildkite-agent/builds/bk-agent-prod-gcp-1737064481463707835/elastic/connectors/dist/dra-artifacts
  | 2025-01-16 15:57:25 CST | total 1.4G
  | 2025-01-16 15:57:25 CST | drwxrwxrwx 2 buildkite-agent buildkite-agent 4.0K Jan 16 21:57 .
  | 2025-01-16 15:57:25 CST | drwxrwxrwx 5 buildkite-agent buildkite-agent 4.0K Jan 16 21:57 ..
  | 2025-01-16 15:57:25 CST | -rw-rw-r-- 1 buildkite-agent buildkite-agent 434K Jan 16 21:57 connectors-9.0.0-alpha1.zip
  | 2025-01-16 15:57:25 CST | -rw-rw-r-- 1 buildkite-agent buildkite-agent 360M Jan 16 21:56 elastic-connectors-9.0.0-alpha1-docker-image-linux-amd64.tar.gz
  | 2025-01-16 15:57:25 CST | -rw-rw-r-- 1 buildkite-agent buildkite-agent 351M Jan 16 21:56 elastic-connectors-9.0.0-alpha1-docker-image-linux-arm64.tar.gz
  | 2025-01-16 15:57:25 CST | -rw-rw-rw- 1 buildkite-agent buildkite-agent 360M Jan 16 21:56 elastic-connectors-9.0.0-docker-image-linux-amd64.tar.gz
  | 2025-01-16 15:57:25 CST | -rw-rw-rw- 1 buildkite-agent buildkite-agent 351M Jan 16 21:56 elastic-connectors-9.0.0-docker-image-linux-arm64.tar.gz
  | 2025-01-16 15:57:25 CST | ++ echo 'We would now execute:
  | 2025-01-16 15:57:25 CST |  
  | 2025-01-16 15:57:25 CST | docker run --rm   --name release-manager   -e VAULT_ADDR   -e VAULT_ROLE_ID   -e VAULT_SECRET_ID   --mount type=bind,readonly=false,src="/opt/buildkite-agent/builds/bk-agent-prod-gcp-1737064481463707835/elastic/connectors/dist",target="/artifacts"   docker.elastic.co/infra/release-manager:latest   cli collect       --project "connectors"       --branch "seanstory/9111-add-dra-qualifier"       --commit "baf771d572ce655fb7efbf8e7d894c3e52d7e873"       --workflow "staging"       --version "9.0.0"       --qualifier "alpha1"       --artifact-set main
  | 2025-01-16 15:57:25 CST | '

@seanstory seanstory changed the title Disable actual DRA publishing Enable basic DRA qualifiers Jan 16, 2025
@seanstory seanstory marked this pull request as ready for review January 16, 2025 22:11
@seanstory seanstory requested a review from a team as a code owner January 16, 2025 22:11
Copy link
Member

@jedrazb jedrazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's test on prod!

@seanstory seanstory enabled auto-merge (squash) January 17, 2025 17:09
@seanstory seanstory merged commit 3a5f1cb into main Jan 17, 2025
2 checks passed
@seanstory seanstory deleted the seanstory/9111-add-dra-qualifier branch January 17, 2025 17:19
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 3119 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants