Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPO] Deduplicate test name #1300

Merged
merged 4 commits into from
Jul 20, 2023
Merged

[SPO] Deduplicate test name #1300

merged 4 commits into from
Jul 20, 2023

Conversation

timgrein
Copy link
Contributor

We had two tests using the same name causing a linter warning. This PR deduplicates the test names.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR has a thorough description

@timgrein timgrein requested a review from a team July 19, 2023 06:54
seanstory
seanstory approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@seanstory seanstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my linter used to complain about this if I ran make lint while in the venv. No idea why it doesn't catch it outside of venv.

Thanks for fixing.

@timgrein
Copy link
Contributor Author

my linter used to complain about this if I ran make lint while in the venv. No idea why it doesn't catch it outside of venv.

Thanks for fixing.

Maybe it was a warning? Would be fixed with #1193.

@timgrein timgrein enabled auto-merge (squash) July 20, 2023 08:11
@timgrein timgrein merged commit 99cf505 into main Jul 20, 2023
@timgrein timgrein deleted the tim/spo-test-deduplicate-test-name branch July 20, 2023 08:16
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jul 20, 2023
@timgrein
[SPO] Deduplicate test name (#1300)
5ad2662
@github-actions
Copy link

💚 Backport PR(s) successfully created

Status Branch Result
✅ pre-8.10-stable #1314

This backport PR will be merged automatically after passing CI.

timgrein pushed a commit that referenced this pull request Jul 20, 2023
@github-actions
[SPO] Deduplicate test name (#1300) (#1314)
c2a3f98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanstory seanstory seanstory approved these changes

Assignees
No one assigned
Labels
auto-backport v8.10.0.0 vpre-8.10-stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timgrein @seanstory