New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't close GzipWriter in a finalizer #1506

Open

estolfo wants to merge 1 commit into elastic:main from estolfo:gzip

Contributor

estolfo commented Dec 13, 2024

Closing the GzipWriter in a finalizer sometimes causes these messages in the apm server, meaning some data could not be received by the server:

[ElasticAPM] APM Server responded with an error:
"{\"accepted\":2,\"errors\":[{\"message\":\"gzip: invalid header\"}]}\n"

Not closing the GzipWriter will instead cause these warnings in the application logs:

zlib(finalizer): Zlib::GzipWriter object must be closed explicitly.
zlib(finalizer): the stream was freed prematurely.


          Don't close gzipwriter in a finalizer

e32756e

estolfo changed the title ~~Don't close gzipwriter in a finalizer~~ Don't close GzipWriter in a finalizer

github-actions bot added the agent-ruby label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels