-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jenkins): support check license with go-licenser #518
Conversation
@v1v can you give a short explanation on the benefits of using go-licenser instead of the relatively simple bash script? One benefit of the bash script is that we can use it very easily in a pre-commit hook: apm-agent-python/.pre-commit-config.yaml Lines 21 to 29 in a2442b3
If we switch to go-licenser, it would be great if that could also be applied to the pre-commit hook somehow to ensure parity between the two checks. |
That's a fair question. The major benefit is to provide the same toolchain for all the agents if possible, I don't say the At the moment the current implementation doesn't provide all the requirements for the python agent though. That's one of the reasons I raised this PR as a draft. Do you think I should move this conversation to an issue firstly rather than in this PR? Are there any concerns in your end? Thanks |
I agree that harmonizing the license check would be great. But if it hugely complicates go-licenser just to be able to handle the Python agent (AFAIK, most other Elastic projects share the same Apache2 license), it might not be worth it. And as I said, having the check work in a pre-commit hook is pretty much a requirement for me. |
I'll close this PR for the time being, and once we go the go-licenser in place we can revisit it. |
zube didn't agree with having this closed. Let's try again |
Highlights
Tasks