Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix decimator #534

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix decimator #534

merged 1 commit into from
Aug 24, 2023

Conversation

pca006132
Copy link
Collaborator

#529 (comment)

  1. DedupeEdge must dedupe the edge with the smallest index. Violating this property will cause 'halfedge_.size() % 6 == 0' is false: Not an even number of faces after sorting faces! .
  2. CollapseTri and RemoveIfFolded can encounter collapsed edges, we should simply skip them.

Closes #529

@pca006132 pca006132 requested a review from elalish August 24, 2023 02:53
@pca006132
Copy link
Collaborator Author

btw for 1, I verified this by inverting the arrays, but I did not commit it here.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cc83e1b) 91.50% compared to head (baea544) 91.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files          35       35           
  Lines        4520     4521    +1     
=======================================
+ Hits         4136     4137    +1     
  Misses        384      384           
Files Changed Coverage Δ
src/manifold/src/edge_op.cpp 95.34% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pca006132 pca006132 merged commit 1514c15 into elalish:master Aug 24, 2023
15 checks passed
@pca006132 pca006132 deleted the decimator-fixes branch August 29, 2023 07:33
@elalish elalish mentioned this pull request Nov 3, 2023
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#528 causes invalid UpdateVert calls
2 participants