Merge pull request #189 from ekristen/fix-settings-refs

fix: add missing settings and settings reference
ekristen · Jun 7, 2024 · 1097aec · 1097aec
2 parents e12be4d + 981c6f2
commit 1097aec
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -151,7 +151,7 @@ func (c *Config) ResolveDeprecatedFeatureFlags() {
 			})
 		}
 		if c.FeatureFlags.DisableDeletionProtection.CloudformationStack {
-			c.Settings.Set("CloudformationStack", &settings.Setting{
+			c.Settings.Set("CloudFormationStack", &settings.Setting{
 				"DisableDeletionProtection": true,
 			})
 		}

diff --git a/pkg/config/config_test.go b/pkg/config/config_test.go
@@ -370,7 +370,7 @@ func TestConfig_DeprecatedFeatureFlags(t *testing.T) {
 	assert.NotNil(t, rdsInstanceSettings)
 	assert.Equal(t, true, rdsInstanceSettings.Get("DisableDeletionProtection"))
 
-	cloudformationStackSettings := c.Settings.Get("CloudformationStack")
+	cloudformationStackSettings := c.Settings.Get("CloudFormationStack")
 	assert.NotNil(t, cloudformationStackSettings)
 	assert.Equal(t, true, cloudformationStackSettings.Get("DisableDeletionProtection"))
 }
diff --git a/resources/cloudformation-stack.go b/resources/cloudformation-stack.go
@@ -33,6 +33,9 @@ func init() {
 		Name:   CloudFormationStackResource,
 		Scope:  nuke.Account,
 		Lister: &CloudFormationStackLister{},
+		Settings: []string{
+			"DisableDeletionProtection",
+		},
 	})
 }
 

diff --git a/resources/rds-instances.go b/resources/rds-instances.go
@@ -22,6 +22,9 @@ func init() {
 		Name:   RDSInstanceResource,
 		Scope:  nuke.Account,
 		Lister: &RDSInstanceLister{},
+		Settings: []string{
+			"DisableDeletionProtection",
+		},
 	})
 }