Add type as part of target location

[Ao-senXiong]

No description provided.

[Ao-senXiong]

Hi @wmdietl, do you know how to update the elementcache in

checker-framework/framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java

Line 529 in c29e50b

private final Map<Element, AnnotatedTypeMirror> elementCache;

.

It is later retrieved at here.

checker-framework/framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java

Line 1663 in c29e50b

return elementCache.get(elt).deepCopy();

The expected error did not come up because in the elementCache it does not contain annotation added from DefaultQualifier.

[Ao-senXiong]

The root cause should be here as the method getTypeDeclarationBounds

checker-framework/framework/src/main/java/org/checkerframework/common/basetype/BaseTypeValidator.java

Line 318 in 93f44a2

atypeFactory.getTypeDeclarationBounds(type.getUnderlyingType());

which does not consider bound in Defaultqualifier annotation like @DefaultQualifier( value = A.class, locations = {TypeUseLocation.TYPE})

[Ao-senXiong]

If the annotation supplied is incompatible with the one in DefaultQualifier, should we report error or we should keep the explicit qualifier? That is to say, in the following code, should we keep @B or should we report error?

@DefaultQualifier(
        value = A.class,
        locations = {TypeUseLocation.TYPE})
@B
public class DefaultQualifierTest {
    @B DefaultQualifierTest() {}
}

[Ao-senXiong]

Also, another question is should we apply the class level default only for toplevel? Or nested classes as well?