Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming throw type and exception parameter err msg to incompatible #618

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Ao-senXiong
Copy link
Member

@Ao-senXiong Ao-senXiong commented Nov 17, 2023

Edit: Merge after #436
I will do the two renaming first as they are the most related to our changes in #436.

Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you look through the manual whether this needs changing somewhere?
This definitely needs a changelog entry.
Can we support both suppression keys for a transition period?

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Nov 30, 2023
@Ao-senXiong
Copy link
Member Author

Ao-senXiong commented Dec 1, 2023

Did you look through the manual whether this needs changing somewhere?

I have looked at the manual and there is no similar message key used in the manual.

This definitely needs a changelog entry

Already add a changelog entry.

Can we support both suppression keys for a transition period?

I have added back to old keys for this transition period.

@Ao-senXiong Ao-senXiong requested a review from wmdietl December 1, 2023 17:55
@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Dec 1, 2023
@wmdietl
Copy link
Member

wmdietl commented Dec 2, 2023

Can we support both suppression keys for a transition period?

I have added back to old keys for this transition period.

You left the old keys in messages.properties, where nobody uses them. You can remove them there.

Can we allow existing @SuppressWarnings that use the old keys to continue to work? Otherwise, we're breaking everyone that currently suppresses these warnings and force them to change the keys.

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Dec 2, 2023
@Ao-senXiong
Copy link
Member Author

Can we support both suppression keys for a transition period?

I have added back to old keys for this transition period.

You left the old keys in messages.properties, where nobody uses them. You can remove them there.

Can we allow existing @SuppressWarnings that use the old keys to continue to work? Otherwise, we're breaking everyone that currently suppresses these warnings and force them to change the keys.

Addressed this comment in 7c26ec1

@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants