fix(maat): proofs #600
fix(maat): proofs #600
Conversation
runtime/src/configs/mod.rs
Outdated
| ( | ||
| T::Hashing::hash(&[]), | ||
| Output::decode(&mut TrailingZeroInput::new(subject)).unwrap_or_default(), |
There was a problem hiding this comment.
TrailingZeroInput adds zeros to subject and then decodes that. In our case we are using empty slice for subject. That is why we get [0; 32] randomness when called. Before the slice was hashed. Now it's only decoded.
While fixing the test I found TestRandomness. The latest commit uses that directly. So that we don't need to support our implementation.
| ) -> [u8; 32] { | ||
| // This randomness digest is hardcoded because it's always same on testnet. | ||
| // Check `PredictableRandomnessSource` struct for more details. | ||
| let digest = [0u8; 32]; |
There was a problem hiding this comment.
But it's not [0u8; 32] on the testnet, right?
There was a problem hiding this comment.
Answered here. It is now :D
| /// Sector number | ||
| #[arg(long)] | ||
| sector_id: u32, | ||
| /// The height at which we draw the randomness for deriving a sealed cid. |
There was a problem hiding this comment.
We should propose the defaults that were hardcoded here, If I were a new user, I wouldn't know where to put it and which number needs to be after which one.
There was a problem hiding this comment.
I thought that we will eventually remove those commands? The defaults were also specific for a single use case
Description
Fixes maat proofs and adds a script for future use.