Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add faucet pallet to CLI #590

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented Nov 19, 2024

Description

This PR adds support for unsigned transactions in the storagext-cli. The traced_submission_with_finalization method has been modified to work with the unsigned transaction. After this change, I tested signed transactions too to make sure nothing broke.

Now that storagext support unsigned transactions the drip function from the faucet pallet has been implemented and can be run with:

storagext-cli faucet drip <ACCOUNT_ID>

TODOs:

  • Update documentation to reflect the storagext CLI change and the pallet implementation.

@aidan46 aidan46 added the enhancement New feature or request label Nov 19, 2024
@aidan46 aidan46 added this to the Phase 3 milestone Nov 19, 2024
@aidan46 aidan46 self-assigned this Nov 19, 2024
@aidan46 aidan46 linked an issue Nov 19, 2024 that may be closed by this pull request
Base automatically changed from 582-feat-add-faucet-pallet to develop November 19, 2024 10:01
@aidan46 aidan46 force-pushed the 583-feat-add-drip-txn-to-storagext branch from 05c02f4 to 8ac4760 Compare November 20, 2024 07:29
@aidan46 aidan46 changed the base branch from develop to main November 20, 2024 07:32
@aidan46 aidan46 changed the base branch from main to develop November 20, 2024 07:32
@aidan46 aidan46 added the ready for review Review is needed label Nov 20, 2024
@aidan46 aidan46 marked this pull request as ready for review November 20, 2024 09:24
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems ok, but I think there's no reason to take out the docs right now.
Having multiple options for people to pick and choose from is generally better

cli/polka-storage/storagext-cli/src/cmd/faucet.rs Outdated Show resolved Hide resolved
@aidan46 aidan46 force-pushed the 583-feat-add-drip-txn-to-storagext branch 2 times, most recently from 68a6c64 to 91fb4aa Compare November 21, 2024 10:32
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Nov 21, 2024
@aidan46 aidan46 requested a review from a team November 21, 2024 10:33
jmg-duarte
jmg-duarte previously approved these changes Nov 21, 2024
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Good job!

@jmg-duarte jmg-duarte force-pushed the 583-feat-add-drip-txn-to-storagext branch from a9adcef to 377a1c2 Compare November 21, 2024 12:17
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Nov 21, 2024
@jmg-duarte jmg-duarte enabled auto-merge (squash) November 21, 2024 12:18
@jmg-duarte jmg-duarte merged commit 21e4b1b into develop Nov 21, 2024
5 checks passed
@jmg-duarte jmg-duarte deleted the 583-feat-add-drip-txn-to-storagext branch November 21, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add drip txn to storagext
3 participants