Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add faucet pallet #584

Merged
merged 6 commits into from
Nov 19, 2024
Merged

feat: Add faucet pallet #584

merged 6 commits into from
Nov 19, 2024

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented Nov 18, 2024

Description

Add a faucet pallet with a drip function that can be used once a day per
account and drips 10UNITs.

Important points for reviewers

To test this run the testnet and open up the polkadot.js web UI. Under extrinsics select the faucet pallet and the drip method, any account can be used to call this (I recommend an injected account/account with no funds). Select the account you want to fund and SUBMIT UNSIGNED. After the txn is included in the block the selected account should have 10 UNITs (or w/e amount you had + 10).

Checklist

Follow-up issue: #583

@aidan46 aidan46 self-assigned this Nov 18, 2024
Add a faucet pallet with a drip function that can be used once a day per
account and drips 10UNITs.
@aidan46 aidan46 added enhancement New feature or request ready for review Review is needed labels Nov 18, 2024
@aidan46 aidan46 added this to the Phase 3 milestone Nov 18, 2024
@aidan46 aidan46 linked an issue Nov 18, 2024 that may be closed by this pull request
@aidan46 aidan46 removed the ready for review Review is needed label Nov 18, 2024
@aidan46 aidan46 added the ready for review Review is needed label Nov 18, 2024
jmg-duarte
jmg-duarte previously approved these changes Nov 18, 2024
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've left some comments for consideration but they're not blockers.

We can handle docs when merging the storagext

runtime/src/configs/mod.rs Outdated Show resolved Hide resolved
pallets/faucet/src/lib.rs Outdated Show resolved Hide resolved
pallets/faucet/src/lib.rs Show resolved Hide resolved
@aidan46 aidan46 requested a review from a team November 18, 2024 09:54
pallets/faucet/src/lib.rs Outdated Show resolved Hide resolved
@aidan46 aidan46 linked an issue Nov 19, 2024 that may be closed by this pull request
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Nov 19, 2024
@aidan46 aidan46 requested a review from a team November 19, 2024 08:40
@jmg-duarte jmg-duarte enabled auto-merge (squash) November 19, 2024 08:48
@jmg-duarte jmg-duarte merged commit e74fcfe into develop Nov 19, 2024
5 checks passed
@jmg-duarte jmg-duarte deleted the 582-feat-add-faucet-pallet branch November 19, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add faucet pallet
3 participants