-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add faucet pallet #584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a faucet pallet with a drip function that can be used once a day per account and drips 10UNITs.
aidan46
force-pushed
the
582-feat-add-faucet-pallet
branch
from
November 18, 2024 07:34
40ace48
to
8b6ec0a
Compare
aidan46
added
enhancement
New feature or request
ready for review
Review is needed
labels
Nov 18, 2024
jmg-duarte
previously approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've left some comments for consideration but they're not blockers.
We can handle docs when merging the storagext
th7nder
requested changes
Nov 18, 2024
Closed
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Nov 19, 2024
th7nder
approved these changes
Nov 19, 2024
jmg-duarte
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a faucet pallet with a drip function that can be used once a day per
account and drips 10UNITs.
Important points for reviewers
To test this run the testnet and open up the polkadot.js web UI. Under extrinsics select the faucet pallet and the drip method, any account can be used to call this (I recommend an injected account/account with no funds). Select the account you want to fund and SUBMIT UNSIGNED. After the txn is included in the block the selected account should have 10 UNITs (or w/e amount you had + 10).
Checklist
Follow-up issue: #583