docs: Implement docs feedback for Chapter 1 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmg-duarte
previously approved these changes
Nov 13, 2024
aidan46
changed the title
Co-authored-by: José Duarte <[email protected]>
aidan46
force-pushed
the
docs/update-after-feedback
branch
from
e42d964
to
9131943
Compare
aidan46
changed the title
th7nder
approved these changes
Nov 14, 2024
cernicc
approved these changes
Nov 14, 2024
jmg-duarte
added
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the feedback based on the notes that Luke gave us for chapter 1: Architecture (+ background and introduction). Please check the notion feedback page to see the feedback.