-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add subscribe flag and event listener #448
Conversation
87897f4
to
7a1d9a1
Compare
55aedbc
to
50fbf67
Compare
d98a2d6
to
7f0ba40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current PR is much larger in scope in comparison with the issue.
The ideas are clearly here, but the PR needs to be trimmed down.
2eb965e
to
0ea6109
Compare
18f45b0
to
75a4435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be drastically simplified.
504a2ae
to
f38ed52
Compare
0ca4fb1
to
4c5add8
Compare
4c5add8
to
2c25b81
Compare
2c25b81
to
3dee807
Compare
1e1919f
to
3dee807
Compare
Pull request was closed
Description
This PR attacks an existing bug in the polkadot-SDK, where subscribing to finalized block events won't be returned in any case. A flag has also been added to decide whether one wants to wait for the finalization of the sent extrinsic.
To workaround the existing bug mentioned in paritytech/subxt#1668, we are now manually listening to events and filtering them for the expected event. A couple of conversions are obsolete by returning the expected event directly. Contained event data can be accessed directly.
Before, one always had to wait for the finalization of the sent extrinsic. Now, one can choose between sending only (not waiting for the extrinsic's result) and waiting for finalization and returning the event and block hash.
Extensive testing on these changes is too much and heavy for one PR - therefore, it has been skipped. The new
wait-for-finalisation
-flag and the new CLI option--skip-finalisation
have been evaluated manually. See follow-up tasks.maat
'sreal_world_use_case
has also been fixed until the step about submitting the windowed PoSt. See #477.There are multiple follow-up tasks:
InvalidPoRepProof
#477Solves: #415, #381.
Checklist