Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For languages like
SymbolLang
that don't have an outer-most enum this allows defining a discriminant and reducing the set of nodes considered for matching. This allows eachLanguage
to determine the type to use for the discriminant and how to compute it.For instance:
std::mem::Discriminant<Self>
if the type is an enumu64
if it is easy to hash the "operation"Symbol
for something like SymbolLang (or a discriminant of the operation, in the case of something like SymbolLang but using an enum for the symbol)ENodeOrVar
.This also allows languages to trade-off how rich the discriminant is with how efficient it is to compute / compare.