This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Develop #797
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package org.egov.wscalculation.repository; | ||
|
|
||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.jdbc.core.JdbcTemplate; | ||
| import org.springframework.stereotype.Component; | ||
| import org.springframework.stereotype.Repository; | ||
|
|
||
| @Component | ||
| @Slf4j | ||
| @Repository | ||
| public class DemandAuditSeqBuilder { | ||
|
|
||
| @Autowired | ||
| private JdbcTemplate jdbcTemplate; | ||
|
|
||
| public static final String SELECT_NEXT_SEQUENCE_USER = "select nextval('seq_eg_ws_demand_auditchange')"; | ||
|
|
||
| public Long getNextSequence() { | ||
| return jdbcTemplate.queryForObject(SELECT_NEXT_SEQUENCE_USER, Long.class); | ||
| } | ||
|
|
||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package org.egov.wscalculation.web.models; | ||
|
|
||
| import lombok.*; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import static org.apache.commons.lang3.StringUtils.isNotEmpty; | ||
|
|
||
|
|
||
| @Getter | ||
| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| @Builder | ||
| @ToString | ||
| public class WsDemandChangeAuditRequest { | ||
| private Long id; | ||
| private String consumercode; | ||
| private String tenant_id; | ||
| private String status; | ||
| private String action; | ||
| private Object data; | ||
| private String createdby; | ||
| private Long createdtime; | ||
| public boolean isValid() { | ||
|
|
||
| return isNotEmpty(consumercode); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||
| package org.egov.wscalculation.web.models; | ||||||
|
|
||||||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||||||
| import com.fasterxml.jackson.annotation.JsonValue; | ||||||
| import lombok.*; | ||||||
|
|
||||||
| @Getter | ||||||
| @AllArgsConstructor | ||||||
| @NoArgsConstructor | ||||||
| @Builder | ||||||
| @ToString | ||||||
| public class WsDemandChangeAuditRequestWrapper { | ||||||
|
|
||||||
| @JsonProperty("WsDemandChangeAuditRequest") | ||||||
|
There was a problem hiding this comment. Correct the - @JsonProperty("WsDemandChangeAuditRequest")
+ @JsonProperty("wsDemandChangeAuditRequest")Committable suggestion
Suggested change
|
||||||
| private WsDemandChangeAuditRequest wsDemandChangeAuditRequest; | ||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -145,3 +145,7 @@ sms.demand.enabled: true | |
| sms.payment.link.enabled: true | ||
| sms.bill.download.enabled: true | ||
| sms.exclude.tenant="pb.testing" | ||
|
|
||
| #SAVE DEMAND AUDIT FROM WS_SERVICE | ||
| is.save.demand.audit.enabled= true | ||
| egov.save.demand.audit.from.wscal= save-ws-demand-change-audit | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| CREATE TABLE IF NOT EXISTS eg_ws_demand_auditchange ( | ||
| id bigint NOT NULL, | ||
| consumercode VARCHAR(30) NOT NULL, | ||
| tenant_id VARCHAR(50), | ||
| status VARCHAR(50), | ||
| action VARCHAR(100), | ||
| data JSONB, | ||
| createdby VARCHAR(250), | ||
| createdtime bigint | ||
|
|
||
| ); | ||
| CREATE SEQUENCE seq_eg_ws_demand_auditchange | ||
| START WITH 1 | ||
| INCREMENT BY 1 | ||
| NO MINVALUE | ||
| NO MAXVALUE | ||
| CACHE 1; | ||
| ALTER TABLE eg_ws_demand_auditchange ADD CONSTRAINT eg_ws_demand_auditchange_pkey PRIMARY KEY (id); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve exception handling by logging the exception details.
This change aligns with the PR's objective to improve exception handling by including the exception itself in the message, rather than just printing it to the console. This will help in better debugging and maintaining the logs.
Committable suggestion
Consider rethrowing the exception or handling it more comprehensively.
This change would allow the exception to be handled or logged by the caller, providing more flexibility in managing errors and aligning with the PR's focus on improved exception handling.
Add type and null checks to prevent potential
ClassCastExceptionorNullPointerException.This change ensures that the message data is of the expected type and contains all required keys, thus preventing runtime exceptions and aligning with best practices for robust and secure code.
Committable suggestion
Refactor to improve readability and maintainability.
Refactoring this method to use a context object for passing parameters can simplify the method signature and improve readability. This change also helps in managing the method's complexity by encapsulating the parameters in a single object.