-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
* Flutter version upgrade Flutter 3.16.0 • channel stable • https://github.com/flutter/flutter.git Framework • revision db7ef5bf9f (10 days ago) • 2023-11-15 11:25:44 -0800 Engine • revision 74d16627b9 Tools • Dart 3.2.0 • DevTools 2.28.2 * fixes for supporting latest version * privacy policy placeholder * privacy policy placeholder * dartfix latest * build gradle upgrade * ios fixes * config changes * updated Deperacated cirrusci to cirruslabs * PFM-5044 * PFM-4878
frontend/mgramseva/lib/providers/user_edit_profile_provider.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add required changes
* PFM-4085 Vendor Report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls make the commented changes
frontend/mgramseva/lib/main.dart
Outdated
@@ -155,7 +165,9 @@ class _MyAppState extends State<MyApp> { | |||
CommonProvider.downloadUrl.remove(id); | |||
} | |||
} | |||
setState(() {}); | |||
setState(() { | |||
print("Download progress: "+progress.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove print statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
frontend/mgramseva/lib/main.dart
Outdated
@@ -143,10 +153,10 @@ class _MyAppState extends State<MyApp> { | |||
String id = data[0]; | |||
DownloadTaskStatus status = data[1]; | |||
int progress = data[2]; | |||
print("Download progress: "+progress.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove print statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
@@ -14,7 +17,8 @@ | |||
<application | |||
android:allowBackup="false" | |||
android:fullBackupContent="false" | |||
android:label="mgramseva" | |||
android:enableOnBackInvokedCallback="true" | |||
android:label="mGramSeva" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls make sure that this won't affect the deployment of app in playStore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, It will not hamper. I have checked.
|
||
class FirebaseConfigurations { | ||
static const _apiKey = "AIzaSyBWQkRGvXiKu_fLAA5O8SvQzZTWeQTqMZ8"; | ||
static const _authDomain = "mgramseva-qa.egov.org.in"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove this when you are merging to master add this to .git ignore file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
|
||
void main() { | ||
HttpOverrides.global = new MyHttpOverrides(); | ||
setPathUrlStrategy(); | ||
//configureApp(); | ||
setEnvironment(Environment.dev); | ||
// Register DartPingIOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add TODO comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
@@ -9,7 +9,7 @@ import 'package:mgramseva/model/mdms/tax_period.dart'; | |||
import '../../repository/water_services_calculation.dart'; | |||
|
|||
class LanguageList { | |||
dynamic? responseInfo; | |||
dynamic responseInfo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls make this to nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
text: TextSpan( | ||
children: <TextSpan>[ | ||
TextSpan( | ||
text: 'By continuing you accept our ', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add the localization key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
() { | ||
if (reportProvider.selectedBillPeriod == null) { | ||
Notifiers.getToastMessage( | ||
context, 'Select Billing Cycle', 'ERROR'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to i18 constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
() { | ||
if (reportProvider.selectedBillPeriod == null) { | ||
Notifiers.getToastMessage( | ||
context, 'Select Billing Cycle', 'ERROR'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to i18 constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for billing-service,echallan-service,vendor,ws-calculator,ws-services
Flutter version upgrade Flutter 3.16.0 • channel stable • https://github.com/flutter/flutter.git Framework • revision db7ef5bf9f (10 days ago) • 2023-11-15 11:25:44 -0800 Engine • revision 74d16627b9
Tools • Dart 3.2.0 • DevTools 2.28.2
fixes for supporting latest version
privacy policy placeholder
privacy policy placeholder
dartfix latest
build gradle upgrade
ios fixes
config changes
updated Deperacated cirrusci to cirruslabs
PFM-5044
PFM-4878