Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Flutter version upgrade (#666) #666

Merged
merged 80 commits into from
Jan 22, 2024
Merged

Flutter version upgrade (#666) #666

merged 80 commits into from
Jan 22, 2024

Conversation

rahuldevgarg
Copy link
Contributor

  • Flutter version upgrade Flutter 3.16.0 • channel stable • https://github.com/flutter/flutter.git Framework • revision db7ef5bf9f (10 days ago) • 2023-11-15 11:25:44 -0800 Engine • revision 74d16627b9
    Tools • Dart 3.2.0 • DevTools 2.28.2

  • fixes for supporting latest version

  • privacy policy placeholder

  • privacy policy placeholder

  • dartfix latest

  • build gradle upgrade

  • ios fixes

  • config changes

  • updated Deperacated cirrusci to cirruslabs

  • PFM-5044

  • PFM-4878

* Flutter version upgrade
Flutter 3.16.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision db7ef5bf9f (10 days ago) • 2023-11-15 11:25:44 -0800
Engine • revision 74d16627b9
Tools • Dart 3.2.0 • DevTools 2.28.2

* fixes for supporting latest version

* privacy policy placeholder

* privacy policy placeholder

* dartfix latest

* build gradle upgrade

* ios fixes

* config changes

* updated Deperacated cirrusci to cirruslabs

* PFM-5044

* PFM-4878
Copy link
Contributor Author

@rahuldevgarg rahuldevgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add required changes

@rahuldevgarg rahuldevgarg changed the title Flutter version upgrade (#657) Flutter version upgrade (#666) Nov 28, 2023
@rahuldevgarg rahuldevgarg added bug Something isn't working enhancement New feature or request labels Nov 28, 2023
@rahuldevgarg rahuldevgarg self-assigned this Nov 28, 2023
Copy link
Contributor

@naveen-egov naveen-egov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls make the commented changes

@@ -155,7 +165,9 @@ class _MyAppState extends State<MyApp> {
CommonProvider.downloadUrl.remove(id);
}
}
setState(() {});
setState(() {
print("Download progress: "+progress.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove print statement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -143,10 +153,10 @@ class _MyAppState extends State<MyApp> {
String id = data[0];
DownloadTaskStatus status = data[1];
int progress = data[2];
print("Download progress: "+progress.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove print statement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -14,7 +17,8 @@
<application
android:allowBackup="false"
android:fullBackupContent="false"
android:label="mgramseva"
android:enableOnBackInvokedCallback="true"
android:label="mGramSeva"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls make sure that this won't affect the deployment of app in playStore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, It will not hamper. I have checked.


class FirebaseConfigurations {
static const _apiKey = "AIzaSyBWQkRGvXiKu_fLAA5O8SvQzZTWeQTqMZ8";
static const _authDomain = "mgramseva-qa.egov.org.in";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove this when you are merging to master add this to .git ignore file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure


void main() {
HttpOverrides.global = new MyHttpOverrides();
setPathUrlStrategy();
//configureApp();
setEnvironment(Environment.dev);
// Register DartPingIOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add TODO comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@@ -9,7 +9,7 @@ import 'package:mgramseva/model/mdms/tax_period.dart';
import '../../repository/water_services_calculation.dart';

class LanguageList {
dynamic? responseInfo;
dynamic responseInfo;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls make this to nullable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

text: TextSpan(
children: <TextSpan>[
TextSpan(
text: 'By continuing you accept our ',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add the localization key

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

() {
if (reportProvider.selectedBillPeriod == null) {
Notifiers.getToastMessage(
context, 'Select Billing Cycle', 'ERROR');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to i18 constants

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

() {
if (reportProvider.selectedBillPeriod == null) {
Notifiers.getToastMessage(
context, 'Select Billing Cycle', 'ERROR');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to i18 constants

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Collaborator

@debasishchakraborty-egovt debasishchakraborty-egovt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for billing-service,echallan-service,vendor,ws-calculator,ws-services

@pradeepkumarcm-egov pradeepkumarcm-egov merged commit 8d38262 into master Jan 22, 2024
1 of 2 checks passed
@rahuldevgarg rahuldevgarg deleted the develop branch January 28, 2024 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants