updating devops file of project-factory #256
Conversation
WalkthroughThis update introduces a new Helm chart for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- deploy-as-code/helm/charts/health-services/project-factory/Chart.yaml (1 hunks)
- deploy-as-code/helm/charts/health-services/project-factory/templates/deployment.yaml (1 hunks)
- deploy-as-code/helm/charts/health-services/project-factory/templates/ingress.yaml (1 hunks)
- deploy-as-code/helm/charts/health-services/project-factory/templates/service.yaml (1 hunks)
- deploy-as-code/helm/charts/health-services/project-factory/values.yaml (1 hunks)
Additional context used
yamllint
deploy-as-code/helm/charts/health-services/project-factory/templates/ingress.yaml
[error] 2-2: syntax error: expected the node content, but found '-'
(syntax)
deploy-as-code/helm/charts/health-services/project-factory/templates/service.yaml
[error] 2-2: syntax error: expected the node content, but found '-'
(syntax)
deploy-as-code/helm/charts/health-services/project-factory/templates/deployment.yaml
[error] 2-2: syntax error: expected the node content, but found '-'
(syntax)
deploy-as-code/helm/charts/health-services/project-factory/Chart.yaml
[error] 26-26: no new line character at the end of file
(new-line-at-end-of-file)
deploy-as-code/helm/charts/health-services/project-factory/values.yaml
[error] 34-34: trailing spaces
(trailing-spaces)
[error] 43-43: trailing spaces
(trailing-spaces)
[error] 48-48: trailing spaces
(trailing-spaces)
[error] 170-170: trailing spaces
(trailing-spaces)
[error] 174-174: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 197-197: trailing spaces
(trailing-spaces)
[error] 205-205: trailing spaces
(trailing-spaces)
[error] 206-206: trailing spaces
(trailing-spaces)
[error] 215-215: trailing spaces
(trailing-spaces)
[error] 223-223: trailing spaces
(trailing-spaces)
[error] 225-225: trailing spaces
(trailing-spaces)
[error] 229-229: trailing spaces
(trailing-spaces)
[error] 231-231: trailing spaces
(trailing-spaces)
[error] 233-233: trailing spaces
(trailing-spaces)
[error] 238-238: trailing spaces
(trailing-spaces)
[error] 251-251: trailing spaces
(trailing-spaces)
[error] 254-254: trailing spaces
(trailing-spaces)
[error] 274-274: no new line character at the end of file
(new-line-at-end-of-file)
| @@ -0,0 +1,2 @@ | |||
| # ingress.yaml | |||
| {{- template "common.ingress" . -}} | |||
There was a problem hiding this comment.
Fix the syntax error in the template directive.
The - character after the template directive might be causing a syntax error. Consider removing it if not needed.
-{{- template "common.ingress" . -}}
+{{ template "common.ingress" . }}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| {{- template "common.ingress" . -}} | |
| {{ template "common.ingress" . }} |
Tools
yamllint
[error] 2-2: syntax error: expected the node content, but found '-'
(syntax)
| dependencies: | ||
| - name: common | ||
| version: 0.0.5 | ||
| repository: file://../../common |
There was a problem hiding this comment.
Add a newline at the end of the file.
Ensure the file ends with a newline character to comply with POSIX standards.
+ Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| repository: file://../../common | |
| repository: file://../../common | |
Tools
yamllint
[error] 26-26: no new line character at the end of file
(new-line-at-end-of-file)
| @@ -0,0 +1,2 @@ | |||
| # service.yaml | |||
| {{- template "common.service" . -}} | |||
There was a problem hiding this comment.
Fix the syntax error in the template directive.
The - character after the template directive might be causing a syntax error. Consider removing it if not needed.
-{{- template "common.service" . -}}
+{{ template "common.service" . }}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| {{- template "common.service" . -}} | |
| {{ template "common.service" . }} |
Tools
yamllint
[error] 2-2: syntax error: expected the node content, but found '-'
(syntax)
| valueFrom: | ||
| configMapKeyRef: | ||
| name: egov-config | ||
| key: kafka-brokers |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces are present in multiple lines. Removing them improves code cleanliness and prevents potential issues with version control systems.
- key: kafka-brokers
+ key: kafka-brokers
- key: egov-mdms-service
+ key: egov-mdms-service
- key: mdms-service-v2
+ key: mdms-service-v2
- secretKeyRef:
+ secretKeyRef:
- valueFrom:
+ valueFrom:
- key: password
+ key: password
- value: {{ .Values.splitBoundariesOn | default "Distrito" }}
+ value: {{ .Values.splitBoundariesOn | default "Distrito" }}
- value: {{ .Values.defaultLocale | default "en_IN" }}
+ value: {{ .Values.defaultLocale | default "en_IN" }}
- value: "userSchema"
+ value: "userSchema"
- value: {{ .Values.logLevel | default "info" }}
+ value: {{ .Values.logLevel | default "info" }}
- value: "Read Me"
+ value: "Read Me"
- value: "true"
+ value: "true"
- value: "eGov@123"
+ value: "eGov@123"
-
+
- value: "true"
+ value: "true"
- value: "true"
+ value: "true"Also applies to: 43-43, 48-48, 170-170, 174-175, 197-197, 205-206, 215-215, 223-223, 225-225, 229-229, 231-231, 233-233, 238-238, 251-251, 254-254
Tools
yamllint
[error] 34-34: trailing spaces
(trailing-spaces)
| @@ -0,0 +1,2 @@ | |||
| # deployment.yaml | |||
| {{- template "common.deployment" . -}} | |||
There was a problem hiding this comment.
Fix the syntax error in the template directive.
The - character after the template directive might be causing a syntax error. Consider removing it if not needed.
-{{- template "common.deployment" . -}}
+{{ template "common.deployment" . }}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| {{- template "common.deployment" . -}} | |
| {{ template "common.deployment" . }} |
Tools
yamllint
[error] 2-2: syntax error: expected the node content, but found '-'
(syntax)
| name: cpu | ||
| target: | ||
| type: Utilization | ||
| averageUtilization: 80 |
There was a problem hiding this comment.
Add a newline at the end of the file.
Ensure the file ends with a newline character to comply with POSIX standards.
+ Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| averageUtilization: 80 | |
| averageUtilization: 80 | |
Tools
yamllint
[error] 274-274: no new line character at the end of file
(new-line-at-end-of-file)
Summary by CodeRabbit
New Features
project-factoryapplication, enabling streamlined deployment within Kubernetes.Bug Fixes
Documentation