-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch2 #15
Open
naveenr-egov
wants to merge
15
commits into
master
Choose a base branch
from
patch2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Patch2 #15
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4724425
mdms model changes
naveenr-egov 77b7368
trip_info ui changes
naveenr-egov 5d7c004
toast ui fix
naveenr-egov 95973a7
added loader for button actions
naveenr-egov ff33588
UI changes as per figma for outline button and icon button
naveenr-egov f2e07e6
changed TripControllers class to singleton to fix the repeated timers…
naveenr-egov 372ac56
added package override of digit components for web
naveenr-egov 7d0e86e
updating current location while ending trip
naveenr-egov 692331f
Update domain url
JithendarKumar-eGov 8eee9c2
Merge pull request #33 from JithendarKumar-eGov/patch-1
naveenr-egov 5312d83
Update sample-env.txt
JithendarKumar-eGov 33012af
Merge pull request #34 from JithendarKumar-eGov/patch-2
naveenr-egov ba6f7a1
Update sample-env.txt
JithendarKumar-eGov 687c127
Merge pull request #35 from JithendarKumar-eGov/patch-3
JithendarKumar-eGov 3805ef4
Update Constants.java
JithendarKumar-eGov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
DB_JDBC_URL=jdbc:postgresql://db-postgresql.com:25060/defaultdb | ||
DB_USER=doadmin | ||
DB_PASSWORD=AVNS_VOzqloso05 | ||
DIGIT_FSM_URL=https://unified-dev.digit.org/fsm/v1/ | ||
DIGIT_VEHICLE_TRIP_URL=https://unified-dev.digit.org/vehicle/trip/v1/ | ||
DIGIT_FSM_URL=https://fsm-demo.digit.org/fsm/v1 | ||
DIGIT_VEHICLE_TRIP_URL=https://fsm-demo.digit.org/vehicle/trip/v1/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
dependency_overrides: | ||
digit_components: | ||
path: ../packages/digit_components |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the typo in the variable name
alartPolygon
toalertPolygon
.Add user feedback (e.g., using a toaster) to inform about the success or failure of adding a new polygon.
Refactor the method to reduce redundancy, especially in the construction of the
LocationDetails
list, to improve code efficiency.