Reading configs from .env with dotenv #16
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egm0121
requested changes
Feb 5, 2023
There was a problem hiding this comment.
Hey @jyjokokk thanks for your contribution, I think it's a useful addition to parse per project settings based on the .env files!
I do have some changes for you to make before I can accept the PR, thanks again for your contribution!
| export const FILE_SUFFIX = process.env.JEST_TEST_GEN_FILESUFFIX; |
There was a problem hiding this comment.
this is not a constant, it is a configuration, no need to read the config inside this file, it can be done in main.ts
| @@ -32,7 +33,7 @@ export function run(args: minimist.ParsedArgs, opts?: TRunOptions) { | |||
| finalOutputDir = path.resolve(finalOutputDir, args.outputDir); | |||
| } | |||
| } | |||
| let fileSuffix = '.generated.test'; | |||
| let fileSuffix = FILE_SUFFIX; | |||
There was a problem hiding this comment.
please keep the default and if specified, override with the process.env.value and finally any command line arguments have priority.
eg:
let fileSuffix = '.generated.test';
if (process.env.JEST_TEST_GEN_FILESUFFIX) {
fileSuffix = process.env.JEST_TEST_GEN_FILESUFFIX;
}
if (args.fileSuffix) {
fileSuffix = args.fileSuffix;
}| @@ -5,6 +5,7 @@ import * as ts from 'typescript'; | |||
| import { parseSourceFile } from './parse-source-file'; | |||
There was a problem hiding this comment.
I think here the should be an import of dotenv at the top to make it work
import * as dotenv from 'dotenv'
dotenv.config()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple addition to reading configurations from .env files in your project root. Currently just switches the fileSuffix, but further additions are easily implemented.